fix(ops): resolve binaries from GOBIN before PATH in manifests_regen - #2009
Open
bwplotka wants to merge 1 commit into
Open
fix(ops): resolve binaries from GOBIN before PATH in manifests_regen#2009bwplotka wants to merge 1 commit into
bwplotka wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates ops/gmpctl/lib.sh to resolve tool paths (yq, helm, and addlicense) from the Go binary directory (GOBIN or GOPATH/bin) before falling back to system-wide commands. The review feedback correctly points out that if go is not installed, executing go env will cause the script to crash under errexit. Additionally, if gobin is empty, checking ${gobin}/tool will incorrectly resolve to /tool. The reviewer provides a robust shell script alternative to safely handle these cases.
bwplotka
force-pushed
the
gmpctl-use-gobin
branch
2 times, most recently
from
July 24, 2026 22:06
40fbc69 to
52c6ca8
Compare
Signed-off-by: bwplotka <bwplotka@google.com>
bwplotka
force-pushed
the
gmpctl-use-gobin
branch
from
July 24, 2026 22:17
52c6ca8 to
50e6785
Compare
bwplotka
commented
Jul 24, 2026
| echo "🔄 Regenerating manifests..." | ||
| YQ="$(command -v yq)" HELM="$(command -v helm)" ADDLICENSE="$(command -v addlicense)" bash "${dir}/hack/presubmit.sh" manifests | ||
| echo "🔄 Regenerating manifests..." | ||
| YQ="${GOBIN}/yq" HELM="${GOBIN}/helm" ADDLICENSE="${GOBIN}/addlicense" bash "${dir}/hack/presubmit.sh" manifests |
Collaborator
Author
There was a problem hiding this comment.
TODO: Check if PATH change can be ignored later on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing discussion comment #2005 (comment) from #2005.
Instead of strictly using
command -vto search$PATH,release-lib::manifests_regennow resolvesyq,helm, andaddlicensefrom$GOBINfirst (falling back to$PATHif not found in$GOBIN).