fix: more graceful handling of SFU join failures - #1853
Merged
Conversation
oliverlaz
requested review from
Copilot,
kristian-mkd,
myandrienko and
santhoshvai
July 14, 2025 09:56
Contributor
There was a problem hiding this comment.
Pull Request Overview
Addresses SFU join failures by tracking retry attempts and requesting a new SFU after repeated errors.
- Tracks per-SFU join failures and sets
migrating_fromon the second failure. - Cleans up the
migrating_fromfield after retries and changesdoJointo private.
Comments suppressed due to low confidence (1)
packages/client/src/Call.ts:872
- The new branch that sets
migrating_fromafter two failures should have corresponding unit tests to verify behavior on both success-after-migration and ultimate failure.
if ((sfuJoinFailures.get(sfuId) || 0) >= 2) {
myandrienko
reviewed
Jul 14, 2025
| } | ||
|
|
||
| // remove the migrating_from field from the join data | ||
| delete joinData.migrating_from; |
Contributor
There was a problem hiding this comment.
Maybe I'm missing something, but what's the point of this? joinData is local to this join() method, so why bother cleaning stuff up?
Member
Author
There was a problem hiding this comment.
We re-use joinData for reconnects. If we keep the migrating_from there, on the next reconnect event, it will "mislead" the coordinator.
oliverlaz
changed the title
myandrienko
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Overview
Keeps track of failed SFU join requests.
Once we fail to connect to the same SFU twice, we ask the Coordinator for another one.
📝 Spec: https://www.notion.so/stream-wiki/SFU-WebSocket-client-tracing-19d6a5d7f9f6806d8a55c4ae0d6a415c
🎫 Ticket: https://linear.app/stream/issue/REACT-488/graceful-sfu-join-failure-handling
🔗 Ref: https://github.com/GetStream/video-sfu/pull/1182