fix(pronto): forward all query parameters - #1847
Merged
Merged
Conversation
oliverlaz
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the sign-in redirect to properly encode the incoming request URL, ensuring all query parameters are preserved post-login.
- Encodes
callbackUrlwithencodeURIComponent - Adds fallback for empty URL string
Comments suppressed due to low confidence (2)
sample-apps/react/react-dogfood/lib/getServerSideCredentialsProps.ts:28
- Consider adding a unit or integration test to confirm that query parameters are correctly encoded and forwarded in the redirect.
destination: `/auth/signin?callbackUrl=${encodeURIComponent(url || '')}`,
sample-apps/react/react-dogfood/lib/getServerSideCredentialsProps.ts:28
- [nitpick] Include a brief comment explaining why
encodeURIComponentis used here to preserve the full query string during redirects.
destination: `/auth/signin?callbackUrl=${encodeURIComponent(url || '')}`,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Overview
Forwards all provided query params to the target route after performing a log-in.
🎫 Ticket: https://linear.app/stream/issue/REACT-445/video-pronto-app-does-not-forward-all-query-params-on-login