feat: clean up stylesheets - #1845
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR refactors sample-app stylesheet imports to use Sass modules, scopes breakpoint mixins under a breakpoints namespace, extracts icon definitions into the sample app, and bumps the Sass dependency to v1.89.2.
- Converted all
@importstatements to@useand updated mixin calls tobreakpoints.respond-above(...) - Moved icon mask definitions from the SDK CSS into the React sample-app’s
icons.scss - Upgraded Sass version and modernized utility mixin property order
Reviewed Changes
Copilot reviewed 62 out of 63 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| style/index.scss | Swapped @import for @use for all partials |
| style/breakpoints.scss | Added @use 'sass:map' and updated map API calls |
| style/icons.scss | Added large set of icon mask definitions locally |
| packages/styling/src/_utils.scss | Modernized apply-mask-image mixin declarations |
| sample-apps/react/messenger-clone/src/styles/index.scss | Replaced CSS imports with meta.load-css and updated vendor CSS paths |
Comments suppressed due to low confidence (2)
sample-apps/react/messenger-clone/src/styles/index.scss:9
- [nitpick] The
meta.load-csscalls mix extension-less and.scssfile names; unify usage (either always include.scssor omit it) to avoid import resolution confusion.
@include meta.load-css('layout');
sample-apps/react/messenger-clone/src/styles/index.scss:3
- Double-check that the path
'stream-chat-react/css/v2/index.css'resolves correctly under Sass module resolution; if it fails, consider using the npm package import syntax (e.g.~stream-chat-react/css/v2/index.css).
@import 'stream-chat-react/css/v2/index.css';
myandrienko
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Overview
The SDK stylesheet had a lot of icons used in our sample apps, unnecessarily increasing the size of the shipped CSS.
This PR moves those icons to the appropriate sample applications and trims around 50KB of SDK CSS.
As part of this refactor, a few more improvements are made:
sassversion