Converge Review on prepared target evidence#1502
Open
limityan wants to merge 1 commit into
Open
Conversation
d9cb7e9 to
1641a62
Compare
1641a62 to
408a910
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR converges Review and Deep Review on one prepared target-evidence path before reviewer execution. Local workspace changes and explicit Git ranges share a session-scoped contract for revisions, exact file scope, change status, completeness, workspace binding, and limitations. Reviewers cannot silently widen that target or fall back to an unrelated baseline.
The final report now carries evidence status separately from the model recommendation. A complete immutable Git range may retain a clean recommendation; mutable workspace evidence is intentionally limited, and limited, stale, failed, or invalid evidence fails closed instead of being presented as approval.
Correctness and execution reliability
Scope and cost boundaries
Compatibility and rollback strategy
review_target_evidence, diff-reference, and incremental-cache fields remain readable when restoring old sessions.Verification
Post-merge measurements
Before any provider or workflow follow-up, observe target-resolution failures, limited-evidence frequency, diff-budget exhaustion, Review completion rate, latency, and token change. A follow-up should be opened only when those measurements identify a frequent, low-coupling decision bottleneck.