Skip to content

refactor : 그룹 가입 요청 목록 조회 - #407

Merged
s-hwan merged 1 commit into
developfrom
BE-54
Nov 9, 2025
Merged

refactor : 그룹 가입 요청 목록 조회 #407
s-hwan merged 1 commit into
developfrom
BE-54

Conversation

@s-hwan

@s-hwan s-hwan commented Nov 2, 2025

Copy link
Copy Markdown
Contributor

📌 Related Issue

BE-54

🚀 Description

  • 기존에 그룹 가입 요청 목록을 조회할 때 lazy 필드에 접근하면서 제대로 값을 가져오지 못했습니다. 이를 해결하기 위해 fetch join으로 미리 로딩 하여 값을 가져오도록 했습니다.

📢 Review Point

@s-hwan s-hwan self-assigned this Nov 2, 2025
@s-hwan s-hwan added the refactoring 리팩토링 label Nov 2, 2025
@linear

linear Bot commented Nov 2, 2025

Copy link
Copy Markdown

@channeltalk

channeltalk Bot commented Nov 2, 2025

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Nov 2, 2025

Copy link
Copy Markdown

Test Results

 27 files   27 suites   6s ⏱️
354 tests 354 ✅ 0 💤 0 ❌
356 runs  356 ✅ 0 💤 0 ❌

Results for commit e80acf7.

@rladmstn rladmstn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Comment on lines +63 to +66
final boolean noAuthority = groupMemberRepository.findByUserAndStudyGroup(user, studyGroup)
.map(RoleOfGroupMember::isParticipant)
.orElse(true);
if (noAuthority) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 리팩토링은 이유가 따로 있으신가유?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가독성 말고는 없습니다!

@sh0723 sh0723 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요~

@s-hwan

s-hwan commented Nov 9, 2025

Copy link
Copy Markdown
Contributor Author

간단한 내용이라 머지하겠습니다

@s-hwan
s-hwan merged commit e10e5a8 into develop Nov 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants