Implement notification preferences and status event timeline

[shyim]

Summary

This PR introduces a comprehensive notification system overhaul, adding user-configurable notification preferences, multi-channel delivery (in-app and email), localized message rendering, and an environment status change timeline.

Key Changes

Notification System Architecture

• New notify package: Separates concerns into Event (what happened), Preferences (who gets notified), Channel (how it's delivered), and Translator (what it says)
• Multi-channel delivery: Implements Channel interface with in-app and email implementations; extensible for future channels (webhook, Slack, etc.)
• Preference resolver: Database-backed PreferenceResolver honors per-user, per-scope, per-event override chain with inheritance (global → organization → environment)

Notification Preferences

• Database schema: New notification_preference table with scope (global/organization/environment) × event type × channel model
• API endpoints:
  • GET/PUT/DELETE /account/notification-preferences for managing preferences
  • GET /notifications/event-types to list available event types and their default channels
• Frontend UI: Settings page with channel toggles and per-event-type controls; environment modal for per-environment subscriptions
• Composable: useNotificationPreferences centralizes preference state across components

Localization & Message Rendering

• Translation keys: Checks and notifications now use messageKey/titleKey with structured params instead of pre-rendered English strings
• Embedded catalogs: Server-side Translator loads locale JSON files (en, de) with {param} interpolation, matching frontend vue-i18n syntax
• Fallback chain: Client prefers translation key (rendered in viewer's locale), falls back to server-rendered message
• User locale: New user.locale column drives server-side email rendering

Status Event Timeline

• New table: environment_status_event records every status transition with reasons (which checks caused it)
• API endpoint: GET /environments/{environmentId}/status-events returns timeline
• Frontend view: DetailStatusHistory.vue displays status changes with check details

Job Refactoring

• Simplified scrape job: environment_scrape_notify.go refactored to use Dispatcher instead of inline notification logic
• Status transition detection: Computes StatusReason array (which checks changed level) for timeline persistence
• Dedup locking: Moved to notify.lockAcquirer for email-level dedup per event type

Account Management

• User profile endpoint: PATCH /account/me now supports updating locale preference
• Subscriber resolution: New GetEnvironmentNotificationSubscribers query for environment-scoped notifications

Notable Implementation Details

• Empty-string sentinels: Notification preference table uses empty strings for "all event types" and "subscription marker" (channel='') to work with UNIQUE constraints
• Tri-state preferences: Event type and per-environment controls are inherit/on/off; channel controls are boolean
• Preference inheritance: Resolver walks scope chain (environment → organization → global) to determine final channel list
• Idempotent in-app delivery: In-app channel upserts on (user_id, key) to avoid duplicates
• Email dedup: Per-event-type TTL-based locks prevent spam (e.g., 1 hour for status degradation)
• Graceful degradation: Missing translation keys return raw key; missing preferences fall back to registry defaults

Files Added

• api/internal/notify/ package (event, channel, dispatcher, preferences, translator, registry, lock)
• api/internal/handler/notification_preference.go
• api/internal/database/queries/notification_preference.sql.go
• api/migrations/000013-000016 (user locale, check keys, preferences, status events)
• Frontend: useNotificationPreferences.ts, EnvironmentNotificationModal.vue, DetailStatusHistory.vue, i18n.ts
• Locale catalogs: api/internal/notify/locales/{en,de}.json

https://claude.ai/code/session_01X2GLoyem7aStcR2K5hx5jq

[shyim]

@copilot resolve the merge conflicts in this pull request

[Copilot]

@copilot resolve the merge conflicts in this pull request

Merged origin/main into the branch. The only conflict was in frontend/src/layouts/AppLayout.vue — resolved by keeping the translation functions (translateNotificationTitle, translateNotificationMessage) from this branch while adopting the updated CSS utility classes (wrap-break-word, wrap-anywhere) from main.

[greptile-apps]

Greptile Summary

This PR delivers a comprehensive notification system overhaul: a new notify package introduces typed events, pluggable delivery channels (in-app and email), per-user preference resolution with a scope inheritance chain, server-side i18n rendering, and an environment status-change timeline backed by a new environment_status_event table.

• New notify package: Dispatcher fans out typed Events to resolved channels; PreferenceResolver walks the environment → org → global scope chain to determine which channels each recipient actually receives; Translator loads embedded locale JSON (en/de) with {param} interpolation matching frontend vue-i18n syntax.
• DB migrations 17–21: add user.locale, environment_check.message_key/params, notification_preference table with subscription-marker sentinel design, environment_status_event table, and a missing ON DELETE CASCADE on user_notification.
• Preference API + frontend: new CRUD endpoints (GET/PUT/DELETE /account/notification-preferences) and useNotificationPreferences composable; both the SET and DELETE handlers guard against writing or removing the subscription-marker row (channel='').

Confidence Score: 5/5

Safe to merge — the core notification dispatch, preference resolver, and DB migrations are correct; the three findings are bounded in impact and do not affect data integrity or security.

The notification architecture is well-structured and the tests cover the preference resolver and dispatcher thoroughly. The two issues in the scrape path are both bounded: the json.Marshal error discard is practically unreachable for a slice of simple structs, and the pre-migration check fallback only affects the brief window between schema deployment and the first rescrape. The notification-before-transaction ordering was already present in the previous architecture; the new timeline entry makes the inconsistency more visible but does not corrupt any existing data.

api/internal/monitoring/scrape/service.go and api/internal/monitoring/scrape/notify.go — the silent error discard and the pre-migration check key fallback both live here.

Important Files Changed

Filename	Overview
api/internal/notify/dispatcher.go	New Dispatcher: resolves per-recipient channel preferences, renders messages per locale, fans out delivery; clean separation of concerns, email dedup lock acquired once per event.
api/internal/notify/preferences.go	queryResolver walks the scope chain (environment → org → global, event-specific → wildcard) correctly; fails open to defaults on DB error; subscription markers (channel='') are safely ignored by the channel name comparison.
api/internal/monitoring/scrape/notify.go	Refactored notification dispatch to use the new Dispatcher; recovery path for pre-migration check rows (MessageKey==nil) falls back to storing rendered English text as a translation key, causing empty reason display in the timeline briefly after deployment.
api/internal/monitoring/scrape/service.go	Notification dispatch now happens before persistScrapeResult's transaction; if the transaction rolls back the in-app notification is committed but the status event timeline entry is not. Also has a silent json.Marshal error discard.
api/internal/handler/notification_preference.go	New preference CRUD handlers; both SET and DELETE guard against the subscription-marker empty channel via validPreferenceChannels; scope validation also present.
api/migrations/000019_notification_preferences.up.sql	Introduces notification_preference table with UNIQUE constraint covering all sentinel columns; data migration from user.notifications JSONB array is correct (handles NULL/empty arrays safely via lateral join).
api/internal/notify/i18n.go	Translator loads embedded locale JSON files; gracefully degrades to raw key on missing translation; interpolation leaves unknown tokens untouched; mirrors frontend vue-i18n {param} syntax.
frontend/src/composables/useNotificationPreferences.ts	Module-level shared refs for preferences/eventTypes; preference lookups mirror server resolver logic (event-specific wins over wildcard); tri-state DELETE/PUT for environment overrides is correct.
api/migrations/000021_user_notification_cascade.up.sql	Adds missing ON DELETE CASCADE to user_notification FK; fixes user deletion failures; aligned with all other user-referencing tables.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant Job as Scrape Job
    participant SVC as scrape.Service
    participant Notifier as notify.Dispatcher
    participant Prefs as PreferenceResolver
    participant InApp as inAppChannel
    participant Email as emailChannel
    participant DB as PostgreSQL
    participant TX as DB Transaction

    Job->>SVC: scrapeEnvironment(env)
    SVC->>DB: GetEnvironmentChecks (old checks)
    SVC->>SVC: handleStatusTransition(oldChecks, newChecks)
    SVC->>DB: GetEnvironmentByID (current status)
    SVC->>SVC: computeStatusReasons()
    SVC->>Notifier: Dispatch(event, recipients)
    loop per recipient
        Notifier->>Prefs: Channels(recipient, event, defaults)
        Prefs->>DB: ListNotificationPreferences(userId)
        Prefs-->>Notifier: resolved channel list
        Notifier->>InApp: Send() → UpsertNotification (committed immediately)
        Notifier->>Email: Send() (if dedup lock acquired)
    end
    Notifier-->>SVC: transition struct
    SVC->>TX: persistScrapeResult (begin transaction)
    TX->>DB: UpdateEnvironmentStatus
    TX->>DB: InsertEnvironmentCheck (×N)
    TX->>DB: InsertEnvironmentStatusEvent
    TX-->>SVC: commit / rollback
    Note over Notifier,TX: Notifications committed before transaction —<br/>timeline entry absent if transaction rolls back

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant Job as Scrape Job
    participant SVC as scrape.Service
    participant Notifier as notify.Dispatcher
    participant Prefs as PreferenceResolver
    participant InApp as inAppChannel
    participant Email as emailChannel
    participant DB as PostgreSQL
    participant TX as DB Transaction

    Job->>SVC: scrapeEnvironment(env)
    SVC->>DB: GetEnvironmentChecks (old checks)
    SVC->>SVC: handleStatusTransition(oldChecks, newChecks)
    SVC->>DB: GetEnvironmentByID (current status)
    SVC->>SVC: computeStatusReasons()
    SVC->>Notifier: Dispatch(event, recipients)
    loop per recipient
        Notifier->>Prefs: Channels(recipient, event, defaults)
        Prefs->>DB: ListNotificationPreferences(userId)
        Prefs-->>Notifier: resolved channel list
        Notifier->>InApp: Send() → UpsertNotification (committed immediately)
        Notifier->>Email: Send() (if dedup lock acquired)
    end
    Notifier-->>SVC: transition struct
    SVC->>TX: persistScrapeResult (begin transaction)
    TX->>DB: UpdateEnvironmentStatus
    TX->>DB: InsertEnvironmentCheck (×N)
    TX->>DB: InsertEnvironmentStatusEvent
    TX-->>SVC: commit / rollback
    Note over Notifier,TX: Notifications committed before transaction —<br/>timeline entry absent if transaction rolls back

Loading

_{Reviews (3): Last reviewed commit: "fix: align notify subscriptions with cap..." | Re-trigger Greptile}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd053b51f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".