Enhance typing feedback - #2
Open
matevskial wants to merge 2 commits into
Open
Conversation
* introduce new socket event "stop-typing" * send "stop-typing" socket event when the user focuses of the message field * send "stop-typing" socket event when the user stops typing in the message field for a second
Owner
|
This looks good as well, but appears to have conflicts because I merged your previous PR. |
Contributor
Author
|
Merge conflicts resolved. I think they appeared because I added new stuff in the existing lines of code instead at the bottom of the file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I discovered you on Youtube and checked your Github repository, thought I might contribute with some ideas.
This PR makes some enhancements to the typing feedback mechanism:
The changes include:
introduce new socket event "stop-typing"
send "stop-typing" socket event when the user focuses of the message
field
send "stop-typing" socket event when the user stops typing in the
message field for a second
I am doing this PR for exercise purposes, would be awesome to hear back from you with some constructive criticism when/if you have time.