fix(widget): restore v1.3.0 config parity and expose OIDC passthrough options - #563
Open
vatsalparikh wants to merge 1 commit into
Open
fix(widget): restore v1.3.0 config parity and expose OIDC passthrough options#563vatsalparikh wants to merge 1 commit into
vatsalparikh wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 603f2e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… options Restore logLevel, middleware, oauthThreshold, tokenStore, prefix for v1.3.0 parity, and expose the OIDC passthrough options par, signOutRedirectUri, loginHint, acrValues, and query on oidcClient.
vatsalparikh
force-pushed
the
SDKS-5216-fix-widget-config
branch
from
July 31, 2026 22:57
fdccd39 to
603f2e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the config options that v1.3.0 (
sdk.config.ts) exposed but the 2.0.0 rewrite dropped, and additionally exposes the OIDC client passthrough options that are reachable through the widget's authorize/logout flow. All new options are optional; existing behavior is unchanged when they are omitted.v1.3.0 parity keys
logLevelconfig.logmiddlewarerequestMiddlewareon both clientsoidcClient.oauthThresholdoidcClientconfig.oauthThresholdoidcClient.tokenStoreoidcClientstorage.type('localStorage'/'sessionStorage'only)oidcClient.prefixoidcClientstorage.prefix(new in v2)OIDC passthrough options (new)
Forwarded verbatim to the SDK — all confirmed consumed at runtime by
@forgerock/oidc-client2.1.0:oidcClient.parbooleanclient.store.js)oidcClient.signOutRedirectUristringpost_logout_redirect_uriforuser.logout()(logout.request.js)oidcClient.loginHintstringclient.store.js)oidcClient.acrValuesstringclient.store.js)oidcClient.queryRecord<string, string>client.store.js)Notes
middlewarekeeps the v1.3.0 option name but uses the v2RequestMiddlewaresignature(req, action, next) => void.tokenStoreaccepts the two string literals only; the v1.3.0 custom token-object store is not supported (v2 persists serialized strings).Testing
pnpm --filter @forgerock/login-widget exec vitest run— 346 tests pass (24 files).svelte-check— 48 errors before and after this change (all pre-existing); zero new type errors introduced.prettier --check .+eslint .— clean.patch).