Sync master: XFL marker fix, CFBF legacy FLA, AppImage boot fix, Next2Flash scaffold - #64
Sync master: XFL marker fix, CFBF legacy FLA, AppImage boot fix, Next2Flash scaffold#64charlieduzstuf wants to merge 8 commits into
Conversation
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR successfully addresses issue #60 by fixing AppImage portable mode detection and improving XFL marker file handling. The implementation adds Linux-specific /proc/self/exe resolution for portable detection and enhances XFL reader logic to correctly handle directory-based projects. All changes are functioning improvements with no critical defects found that would block merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
There was a problem hiding this comment.
Pull request overview
Synchronizes master with fixes and scaffolding previously snapshotted elsewhere: improves Flash/XFL import robustness (marker-file handling and legacy binary FLA bitmap recovery), fixes Linux AppImage “portable” boot detection (issue #60), and adds a Next2Flash integration stub/contract for future AS3 support.
Changes:
- Fix XFL “marker file” handling so selecting
<name>.xflinside a directory-based XFL resolves to the actual project root directory. - Improve legacy (OLE2/CFBF) binary FLA bitmap recovery by carving per-stream rather than scanning the whole file blob.
- Make AppImages boot reliably by bundling
portablestuff/next to the mounted executable and detecting portable installs via/proc/self/exe; add Next2Flash bridge scaffold files.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/flash/xfl_handler.py | Detects ZIP vs directory-marker XFL inputs; resolves marker file to parent folder. |
| tools/flash/next2flash/README.md | Documents current Next2Flash merge status and vendoring plan. |
| tools/flash/next2flash/flare_as3_bridge.py | Adds stub CLI contract for optional AS3 tooling (status/decompile/compile/patch). |
| flare/sources/flare/flashimport.cpp | Adds minimal CFBF reader for legacy FLA bitmap recovery; improves XFL marker handling during import. |
| flare/sources/common/tapptools/tenv.cpp | Linux portable-mode detection via /proc/self/exe to support AppImage runtime layout. |
| flare/sources/common/flash/XFLReader.cpp | Fixes directory-based XFL marker-file selection by resolving to parent directory. |
| .github/workflows/workflow_linux.yml | Bundles portablestuff/ next to AppImage binary and keeps a copy for tarball users. |
| .github/workflows/nightly.yml | Same as above for nightly AppImage generation. |
| @staticmethod | ||
| def _looks_like_zip(path: str) -> bool: | ||
| """Return True if *path* is a file beginning with the ZIP signature.""" | ||
| if not os.path.isfile(path): | ||
| return False | ||
| try: | ||
| with open(path, 'rb') as f: | ||
| return f.read(2) == b'PK' | ||
| except OSError: | ||
| return False |
There was a problem hiding this comment.
Fixed: now checks the full 4-byte ZIP local-file-header signature (PK\x03\x04) instead of just 'PK', so a text marker file starting with those two bytes can't be misclassified.
🤖 Addressed by Claude Code
| quint32 start = u32(m_dir, i + 116); | ||
| quint64 size = static_cast<quint64>(u32(m_dir, i + 120)) | | ||
| (static_cast<quint64>(u32(m_dir, i + 124)) << 32); | ||
| QByteArray blob = (size < m_miniCutoff) | ||
| ? readMini(start, static_cast<quint32>(size)) | ||
| : readChain(start).left(static_cast<int>(size)); | ||
| if (!blob.isEmpty()) out.append(blob); |
There was a problem hiding this comment.
Fixed: clamp against the actual read chain length (min(size, blob.size())) before calling left(), instead of casting the 64-bit size straight to int.
🤖 Addressed by Claude Code
|
Automated build logs – Windows (truncated) --- CMake configure log --- --- Build log --- --- Smoke test (DLL check + launch test) --- --- DLLs present in FlarePortable (root) --- --- dumpbin /DEPENDENTS FlarePortable\Flare.exe --- --- Runtime launch test (8-second timeout, hidden window) --- Note: log files missing – checkout or prior step may have failed. |
|
Automated build logs – macOS (truncated) --- CMake configure log --- --- Build log --- --- Smoke test (dylib check + launch test) --- Note: log files missing – checkout or prior step may have failed. |
|
Automated build logs – Linux (clang) (truncated) --- CMake configure log --- This warning is for project developers. Use -Wno-dev to suppress it. -- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") subdir: flare_legacy (application) -- Build files have been written to: /home/runner/work/Flare/Flare/flare/build --- Build log --- ... (truncated) ... es/tnzcore.dir//common/tvectorimage/outlineApproximation.cpp.o --- Smoke test (launch check) --- |
|
Automated build logs – Linux (gcc) (truncated) --- CMake configure log --- This warning is for project developers. Use -Wno-dev to suppress it. -- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") subdir: flare_legacy (application) -- Build files have been written to: /home/runner/work/Flare/Flare/flare/build --- Build log --- ... (truncated) ... e/flare/build/tnzcore//include/../../../../sources/include/tsmartpointer.h:142:25, --- Smoke test (launch check) --- |
|
CI status for commit ec439f4 (branch flash-xfl-cfbf-sync)
❌ One or more platform workflows failed. Please check the logs in the respective workflow runs. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| if (srcInfo.isFile()) { | ||
| xflDir = fp.getParentDir(); | ||
| xflDirPath = xflDir.getQString(); | ||
| } |
There was a problem hiding this comment.
Fixed: now checks XFL::isXFLDirectory(parentDir) before treating the parent as the project root, so a non-marker .xfl file elsewhere isn't silently redirected to the wrong folder.
🤖 Addressed by Claude Code
| QByteArray readChain(quint32 start) const { | ||
| QByteArray out; | ||
| const QVector<quint32> secs = chainSectors(start); | ||
| for (quint32 s : secs) out += sector(s); | ||
| return out; | ||
| } |
There was a problem hiding this comment.
Fixed: readChain() now reserves capacity up front (secs.size() * m_secSize) before appending sectors, avoiding repeated reallocation for large multi-sector streams.
🤖 Addressed by Claude Code
|
Superseded by #61 (conflicts resolved there directly). |
|
Automated build logs – macOS (truncated) --- CMake configure log --- subdir: flare_legacy (application) -- Build files have been written to: /Users/runner/work/Flare/Flare/flare/build --- Build log --- ... (truncated) ... l.h:2463:13: note: 'glDisableClientState' has been explicitly marked deprecated here --- Smoke test (dylib check + launch test) --- |
|
Automated build logs – Linux (gcc) (truncated) --- CMake configure log --- This warning is for project developers. Use -Wno-dev to suppress it. -- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") subdir: flare_legacy (application) -- Build files have been written to: /home/runner/work/Flare/Flare/flare/build --- Build log --- ... (truncated) ... p.o --- Smoke test (launch check) --- |
|
Automated build logs – Windows (truncated) --- CMake configure log --- Environment variable Boost_ROOT is set to: For compatibility, CMake is ignoring the variable. CMake Warning (dev) at D:/a/Flare/Flare/vcpkg/scripts/buildsystems/vcpkg.cmake:939 (_find_package): Call Stack (most recent call first): -- Found Boost: C:/local/boost_1_87_0 (found suitable version "1.87.0", minimum required is "1.55") -- Build files have been written to: D:/a/Flare/Flare/build --- Build log --- 1>Checking Build System
lrelease czech/colorfx.qm ... (truncated) ... 5207\include\map(72,7): D:\a\Flare\Flare\flare\sources\include\flareqt\menubarcommand.h(130,31): warning C4251: 'CommandManager::m_qactionTable': 'std::map<QAction *,CommandManager::Node *,std::less<QAction *>,std::allocator<std::pair<QAction *const ,CommandManager::Node *>>>' needs to have dll-interface to be used by clients of 'CommandManager' [D:\a\Flare\Flare\build\flare_legacy\Flare.vcxproj] D:\a\Flare\Flare\flare\sources\include\flareqt\menubarcommand.h(131,33): warning C4251: 'CommandManager::m_shortcutTable': 'std::map<std::string,CommandManager::Node *,std::lessstd::string,std::allocator<std::pair<const std::string,CommandManager::Node *>>>' needs to have dll-interface to be used by clients of 'CommandManager' [D:\a\Flare\Flare\build\flare_legacy\Flare.vcxproj] D:\a\Flare\Flare\flare\sources\include\flareqt\selection.h(89,28): warning C4251: 'TSelection::m_alternativeCommandNames': 'QMap<CommandId,QString>' needs to have dll-interface to be used by clients of 'TSelection' [D:\a\Flare\Flare\build\flare_legacy\Flare.vcxproj] moc_xdtsimportpopup.cpp D:\a\Flare\Flare\flare\sources\include\tcolorstyles.h(120,16): warning C4251: 'TColorStyle::m_globalName': 'std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t>>' needs to have dll-interface to be used by clients of 'TColorStyle' [D:\a\Flare\Flare\build\flare_legacy\Flare.vcxproj] D:\a\Flare\Flare\flare\sources\include\tcolorstyles.h(121,16): warning C4251: 'TColorStyle::m_originalName': 'std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t>>' needs to have dll-interface to be used by clients of 'TColorStyle' [D:\a\Flare\Flare\build\flare_legacy\Flare.vcxproj] D:\a\Flare\Flare\flare\sources\include\tcolorstyles.h(133,7): warning C4251: 'TColorStyle::m_pickedPosition': 'TColorStyle::PickedPosition' needs to have dll-interface to be used by clients of 'TColorStyle' [D:\a\Flare\Flare\build\flare_legacy\Flare.vcxproj] moc_canon.cpp --- Smoke test (DLL check + launch test) --- --- DLLs present in FlarePortable (root) --- ... (truncated) ... Scriptd.dll --- dumpbin /DEPENDENTS FlarePortable\Flare.exe --- --- Runtime launch test (8-second timeout, hidden window) --- |
|
Automated build logs – Linux (clang) (truncated) --- CMake configure log --- This warning is for project developers. Use -Wno-dev to suppress it. -- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") subdir: flare_legacy (application) -- Build files have been written to: /home/runner/work/Flare/Flare/flare/build --- Build log --- ... (truncated) ... p.o --- Smoke test (launch check) --- |
ede3f9e to
c8cc5c9
Compare
|
Automated build logs – Linux (gcc) (truncated) --- CMake configure log --- This warning is for project developers. Use -Wno-dev to suppress it. -- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") subdir: flare_legacy (application) -- Build files have been written to: /home/runner/work/Flare/Flare/flare/build --- Build log --- ... (truncated) ... oc_svncommitdialog.cpp.o --- Smoke test (launch check) --- |
|
Automated build logs – Linux (clang) (truncated) --- CMake configure log --- This warning is for project developers. Use -Wno-dev to suppress it. -- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") subdir: flare_legacy (application) -- Build files have been written to: /home/runner/work/Flare/Flare/flare/build --- Build log --- ... (truncated) ... 51/1611] Building CXX object flare_legacy/CMakeFiles/Flare.dir//flare/moc_styleshortcutswitchablepanel.cpp.o --- Smoke test (launch check) --- |
|
CI status for commit c8cc5c9 (branch flash-xfl-cfbf-sync)
❌ One or more platform workflows failed. Please check the logs in the respective workflow runs. |
|
Automated build logs – macOS (truncated) --- CMake configure log --- --- Build log --- --- Smoke test (dylib check + launch test) --- Note: log files missing – checkout or prior step may have failed. |
|
Automated build logs – Linux (gcc) (truncated) --- CMake configure log --- This warning is for project developers. Use -Wno-dev to suppress it. -- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") subdir: flare_legacy (application) -- Build files have been written to: /home/runner/work/Flare/Flare/flare/build --- Build log --- ... (truncated) ... oc_svncommitdialog.cpp.o --- Smoke test (launch check) --- |
|
Automated build logs – Linux (clang) (truncated) --- CMake configure log --- This warning is for project developers. Use -Wno-dev to suppress it. -- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") subdir: flare_legacy (application) -- Build files have been written to: /home/runner/work/Flare/Flare/flare/build --- Build log --- ... (truncated) ... 51/1611] Building CXX object flare_legacy/CMakeFiles/Flare.dir//flare/moc_styleshortcutswitchablepanel.cpp.o --- Smoke test (launch check) --- |
|
CI status for commit 1756ef4 (branch flash-xfl-cfbf-sync)
❌ One or more platform workflows failed. Please check the logs in the respective workflow runs. |
|
CI status for commit 1756ef4 (branch flash-xfl-cfbf-sync)
❌ One or more platform workflows failed. Please check the logs in the respective workflow runs. |
|
Automated build logs – Linux (gcc) (truncated) --- CMake configure log --- This warning is for project developers. Use -Wno-dev to suppress it. -- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") subdir: flare_legacy (application) -- Build files have been written to: /home/runner/work/Flare/Flare/flare/build --- Build log --- ... (truncated) ... oc_svncommitdialog.cpp.o --- Smoke test (launch check) --- |
- abc_editor.py: remove CONSTANT_Double/True/False/Null and _BRANCH_OPCODES (all defined but never referenced anywhere in the file), and the unused end_pos local (computed, never read afterward). - abc_parser.py: don't capture the final _parse_method_bodies() return into p - it's the last statement in the function and the value was never used. - helpers.py: remove the unused logging import and log logger instance (nothing in the file ever calls log.*). Re-verified: package imports cleanly, all three key exports present, bridge status/decompile still work end-to-end against a real SWF. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
CI status for commit 8a02770 (branch flash-xfl-cfbf-sync)
⏳ Waiting for remaining platform workflows to complete. |
|
Automated build logs – Windows (truncated) --- CMake configure log --- Environment variable Boost_ROOT is set to: For compatibility, CMake is ignoring the variable. CMake Warning (dev) at D:/a/Flare/Flare/vcpkg/scripts/buildsystems/vcpkg.cmake:939 (_find_package): Call Stack (most recent call first): -- Found Boost: C:/local/boost_1_87_0 (found suitable version "1.87.0", minimum required is "1.55") -- Build files have been written to: D:/a/Flare/Flare/build --- Build log --- 1>Checking Build System lrelease german/colorfx.qm
lrelease czech/flareqt.qm
... (truncated) ... ::removeEdge' D:\a\Flare\Flare\flare\sources\include\tmeshimage.h(117,73): warning C4661: 'void tcg::Mesh<TTextureVertex,tcg::Edge,tcg::FaceN<3>>::removeFace(int)': no suitable definition provided for explicit template instantiation request [D:\a\Flare\Flare\build\tnzcore\tnzcore.vcxproj] D:\a\Flare\Flare\flare\sources\include\tmeshimage.h(117,73): warning C4661: 'int tcg::Mesh<TTextureVertex,tcg::Edge,tcg::FaceN<3>>::edgeInciding(int,int,int) const': no suitable definition provided for explicit template instantiation request [D:\a\Flare\Flare\build\tnzcore\tnzcore.vcxproj] D:\a\Flare\Flare\flare\sources\include\tmeshimage.h(117,73): warning C4661: 'void tcg::Mesh<TTextureVertex,tcg::Edge,tcg::FaceN<3>>::squeeze(void)': no suitable definition provided for explicit template instantiation request [D:\a\Flare\Flare\build\tnzcore\tnzcore.vcxproj] D:\a\Flare\Flare\flare\sources\include\tmeshimage.h(118,76): warning C4661: 'tcg::TriMesh<TTextureVertex,tcg::Edge,tcg::FaceN<3>>::TriMesh(int)': no suitable definition provided for explicit template instantiation request [D:\a\Flare\Flare\build\tnzcore\tnzcore.vcxproj] D:\a\Flare\Flare\flare\sources\include\tmeshimage.h(118,76): warning C4661: 'int tcg::TriMesh<TTextureVertex,tcg::Edge,tcg::FaceN<3>>::addFace(V &,V &,V &)': no suitable definition provided for explicit template instantiation request [D:\a\Flare\Flare\build\tnzcore\tnzcore.vcxproj] D:\a\Flare\Flare\flare\sources\include\tmeshimage.h(118,76): warning C4661: 'int tcg::TriMesh<TTextureVertex,tcg::Edge,tcg::FaceN<3>>::otherFaceVertex(int,int) const': no suitable definition provided for explicit template instantiation request [D:\a\Flare\Flare\build\tnzcore\tnzcore.vcxproj] D:\a\Flare\Flare\flare\sources\include\tmeshimage.h(118,76): warning C4661: 'int tcg::TriMesh<TTextureVertex,tcg::Edge,tcg::FaceN<3>>::otherFaceEdge(int,int) const': no suitable definition provided for explicit template instantiation request [D:\a\Flare\Flare\build\tnzcore\tnzcore.vcxproj] D:\a\Flare\Flare\flare\sources\include\tmeshimage.h(118,76): warning C4661: 'int tcg::TriMesh<TTextureVertex,tcg::Edge,tcg::FaceN<3>>::swapEdge(int)': no suitable definition provided for explicit template instantiation request [D:\a\Flare\Flare\build\tnzcore\tnzcore.vcxproj] D:\a\Flare\Flare\flare\sources\include\tmeshimage.h(118,76): warning C4661: 'int tcg::TriMesh<TTextureVertex,tcg::Edge,tcg::FaceN<3>>::collapseEdge(int)': no suitable definition provided for explicit template instantiation request [D:\a\Flare\Flare\build\tnzcore\tnzcore.vcxproj] D:\a\Flare\Flare\flare\sources\include\tmeshimage.h(118,76): warning C4661: 'int tcg::TriMesh<TTextureVertex,tcg::Edge,tcg::FaceN<3>>::splitEdge(int)': no suitable definition provided for explicit template instantiation request [D:\a\Flare\Flare\build\tnzcore\tnzcore.vcxproj] drawutil.cpp --- Smoke test (DLL check + launch test) --- --- DLLs present in FlarePortable (root) --- --- dumpbin /DEPENDENTS FlarePortable\Flare.exe --- --- Runtime launch test (8-second timeout, hidden window) --- |
|
Automated build logs – Linux (clang) (truncated) --- CMake configure log --- This warning is for project developers. Use -Wno-dev to suppress it. -- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") subdir: flare_legacy (application) -- Build files have been written to: /home/runner/work/Flare/Flare/flare/build --- Build log --- ... (truncated) ... 51/1611] Building CXX object flare_legacy/CMakeFiles/Flare.dir//flare/moc_styleshortcutswitchablepanel.cpp.o --- Smoke test (launch check) --- |
|
Automated build logs – macOS (truncated) --- CMake configure log --- --- Build log --- --- Smoke test (dylib check + launch test) --- Note: log files missing – checkout or prior step may have failed. |
|
CI status for commit 8a02770 (branch flash-xfl-cfbf-sync)
❌ One or more platform workflows failed. Please check the logs in the respective workflow runs. |
| # Build source | ||
| lines: List[str] = [] | ||
| # Header comment with full class name (like AS3 Sorcerer) | ||
| full_name = f'{pkg}.{class_name}' if pkg else class_name |
| # Also scan QName multinames for built-in class references | ||
| for _mn_kind, _mn_data in abc.multinames: | ||
| if _mn_kind in (MN_QName, MN_QNameA) and _mn_data and len(_mn_data) >= 2: | ||
| _mn_fqn = None |
| parts = [] | ||
| for sci in sibling_classes: | ||
| sinst = abc.instances[sci] | ||
| scls = abc.classes[sci] |
|
Automated build logs – Linux (gcc) (truncated) --- CMake configure log --- This warning is for project developers. Use -Wno-dev to suppress it. -- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") subdir: flare_legacy (application) -- Build files have been written to: /home/runner/work/Flare/Flare/flare/build --- Build log --- ... (truncated) ... oc_svncommitdialog.cpp.o --- Smoke test (launch check) --- |
|
Automated build logs – Linux (clang) (truncated) --- CMake configure log --- This warning is for project developers. Use -Wno-dev to suppress it. -- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") subdir: flare_legacy (application) -- Build files have been written to: /home/runner/work/Flare/Flare/flare/build --- Build log --- ... (truncated) ... 51/1611] Building CXX object flare_legacy/CMakeFiles/Flare.dir//flare/moc_styleshortcutswitchablepanel.cpp.o --- Smoke test (launch check) --- |
| # Valid ZIP magic numbers: local file header (normal case), end-of-central- | ||
| # directory record (a valid but empty archive), and the spanned/split | ||
| # archive marker. Checking only PK\x03\x04 would misclassify the latter two | ||
| # as "not zip" and send a legitimate ZIP-based FLA/XFL down the wrong path. | ||
| _ZIP_SIGNATURES = (b'PK\x03\x04', b'PK\x05\x06', b'PK\x07\x08') |
|
CI status for commit c64e6d6 (branch flash-xfl-cfbf-sync)
⏳ Waiting for remaining platform workflows to complete. |
2 similar comments
|
CI status for commit c64e6d6 (branch flash-xfl-cfbf-sync)
⏳ Waiting for remaining platform workflows to complete. |
|
CI status for commit c64e6d6 (branch flash-xfl-cfbf-sync)
⏳ Waiting for remaining platform workflows to complete. |
|
Automated build logs – macOS (truncated) --- CMake configure log --- subdir: flare_legacy (application) -- Build files have been written to: /Users/runner/work/Flare/Flare/flare/build --- Build log --- ... (truncated) ... 13: note: 'glDrawArrays' has been explicitly marked deprecated here --- Smoke test (dylib check + launch test) --- |
|
CI status for commit c64e6d6 (branch flash-xfl-cfbf-sync)
❌ One or more platform workflows failed. Please check the logs in the respective workflow runs. |
|
Automated build logs – Windows (truncated) --- CMake configure log --- Environment variable Boost_ROOT is set to: For compatibility, CMake is ignoring the variable. CMake Warning (dev) at D:/a/Flare/Flare/vcpkg/scripts/buildsystems/vcpkg.cmake:939 (_find_package): Call Stack (most recent call first): -- Found Boost: C:/local/boost_1_87_0 (found suitable version "1.87.0", minimum required is "1.55") -- Build files have been written to: D:/a/Flare/Flare/build --- Build log --- 1>Checking Build System
lrelease korean/colorfx.qm
N.B. Make sure you are not running another process of Flare, Updating 'D:/a/Flare/Flare/flare/sources/../../stuff/config/loc/russian/image.qm'...
lrelease russian/colorfx.qm
Updating 'D:/a/Flare/Flare/flare/sources/../../stuff/config/loc/spanish/image.qm'...
Updating 'D:/a/Flare/Flare/flare/sources/../../stuff/config/loc/russian/colorfx.qm'...
... (truncated) ... prise\VC\Tools\MSVC\14.44.35207\include\map(72,7): D:\a\Flare\Flare\flare\sources\include\flareqt\menubarcommand.h(130,31): warning C4251: 'CommandManager::m_qactionTable': 'std::map<QAction *,CommandManager::Node *,std::less<QAction *>,std::allocator<std::pair<QAction *const ,CommandManager::Node *>>>' needs to have dll-interface to be used by clients of 'CommandManager' [D:\a\Flare\Flare\build\flare_legacy\Flare.vcxproj] D:\a\Flare\Flare\flare\sources\include\flareqt\menubarcommand.h(131,33): warning C4251: 'CommandManager::m_shortcutTable': 'std::map<std::string,CommandManager::Node *,std::lessstd::string,std::allocator<std::pair<const std::string,CommandManager::Node *>>>' needs to have dll-interface to be used by clients of 'CommandManager' [D:\a\Flare\Flare\build\flare_legacy\Flare.vcxproj] D:\a\Flare\Flare\flare\sources\include\flareqt\selection.h(89,28): warning C4251: 'TSelection::m_alternativeCommandNames': 'QMap<CommandId,QString>' needs to have dll-interface to be used by clients of 'TSelection' [D:\a\Flare\Flare\build\flare_legacy\Flare.vcxproj] moc_expressionreferencemanager.cpp D:\a\Flare\Flare\flare\sources\include\tcolorstyles.h(120,16): warning C4251: 'TColorStyle::m_globalName': 'std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t>>' needs to have dll-interface to be used by clients of 'TColorStyle' [D:\a\Flare\Flare\build\flare_legacy\Flare.vcxproj] D:\a\Flare\Flare\flare\sources\include\tcolorstyles.h(121,16): warning C4251: 'TColorStyle::m_originalName': 'std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t>>' needs to have dll-interface to be used by clients of 'TColorStyle' [D:\a\Flare\Flare\build\flare_legacy\Flare.vcxproj] D:\a\Flare\Flare\flare\sources\include\tcolorstyles.h(133,7): warning C4251: 'TColorStyle::m_pickedPosition': 'TColorStyle::PickedPosition' needs to have dll-interface to be used by clients of 'TColorStyle' [D:\a\Flare\Flare\build\flare_legacy\Flare.vcxproj] moc_stopmotionlight.cpp --- Smoke test (DLL check + launch test) --- --- DLLs present in FlarePortable (root) --- ... (truncated) ... l.dll --- dumpbin /DEPENDENTS FlarePortable\Flare.exe --- --- Runtime launch test (8-second timeout, hidden window) --- |
|
CI status for commit c64e6d6 (branch flash-xfl-cfbf-sync)
❌ One or more platform workflows failed. Please check the logs in the respective workflow runs. |
|
CI status for commit c64e6d6 (branch flash-xfl-cfbf-sync)
❌ One or more platform workflows failed. Please check the logs in the respective workflow runs. |
3 commits pushed to fix/appimage-preset-readme-flash after #59's squash-merge snapshotted; master was missing them. Brings master: directory-XFL marker-file fix, CFBF legacy-FLA bitmap recovery, AppImage FLAREROOT boot fix (#60), Next2Flash bridge scaffold.