Skip to content

fix: fabric spellbook scrolling #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IridescentVoid merged 4 commits into from
Aug 5, 2026
Merged

fix: fabric spellbook scrolling #1237

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23a5203
fix: fabric spellbook scrolling
Olfi01 Aug 5, 2026
50744be
chore: add changelog entry
Olfi01 Aug 5, 2026
0dc2def
chore: Undo rename of method parameters
Olfi01 Aug 5, 2026
894374e
chore: revert changelog entry
Olfi01 Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Fabric/src/main/java/at/petrak/hexcasting/fabric/mixin/client/FabricMouseHandlerMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
package at.petrak.hexcasting.fabric.mixin.client;

import at.petrak.hexcasting.fabric.event.MouseScrollCallback;
import com.llamalad7.mixinextras.sugar.Local;
import net.minecraft.client.MouseHandler;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import org.spongepowered.asm.mixin.injection.callback.LocalCapture;

@Mixin(MouseHandler.class)
public class FabricMouseHandlerMixin {
@Inject(method = "onScroll", cancellable = true, locals = LocalCapture.CAPTURE_FAILSOFT, at = @At(value = "INVOKE", target = "Lnet/minecraft/client/player/LocalPlayer;isSpectator()Z"))
private void onScroll(long winptr, double xOff, double yOff, CallbackInfo ci, double delta) {
@Inject(method = "onScroll", cancellable = true, at = @At(value = "INVOKE", target = "Lnet/minecraft/client/player/LocalPlayer;isSpectator()Z"))
private void onScroll(long winptr, double xOff, double yOff, CallbackInfo ci, @Local(name = "n") int delta) {
var cancel = MouseScrollCallback.EVENT.invoker().interact(delta);
if (cancel) {
ci.cancel();
Expand Down
Loading