Fix masternode collateral vin validation#9
Open
NateIsern wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
vin.prevout.noutput itself to matchMASTER_NODE_AMOUNT * COINand pay to the collateral pubkey by changingIsVinAssociatedWithPubkey()to inspecttxVin.vout[vin.prevout.n]instead of scanning all outputs. (src/obfuscation.cpp)MASTER_NODE_AMOUNT * COINamount instead of4999.99 * COINin masternode liveness, broadcast admission, and legacydseepaths. (src/masternode.cpp, src/masternodeman.cpp)Fix masternode collateral vin validation.Testing
git diff --checkwith no issues reported. (succeeded)./autogen.shin this environment and it failed due to missingaclocal(environment dependency), so a full build/test could not be executed here. (failed due to environment)rg) and inspected the resulting diffs to confirm the intended changes were applied. (inspection only)Codex Task