Restore fail-closed crypto library guard#16
Open
NateIsern wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
libcryptoby restoring the original fail-closed guard so the build refuses to proceed by default whenRAND_egdis missing, avoiding a consensus-sensitive binary divergence risk.Description
AC_CHECK_LIB([crypto],[RAND_egd])behavior with anAC_ARG_WITH([libressl])block that emits an explicit warning only when--with-libresslis supplied and otherwise fails withAC_MSG_ERROR, restoring the previous fail-closed guard inconfigure.ac.Testing
AC_ARG_WITH([libressl])block is present and the prior "Continuing anyway" warning is absent, rangit diff --checkwhich passed, and attemptedautoconfwhich failed in this container due to missing Automake/pkg-config macro definitions (expected environment limitation).Codex Task