Bind spork signatures to network#13
Open
NateIsern wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
nSporkID,nValue, andnTimeSignedwhile mainnet and testnet shared the sameSporkKey.MessageStartbytes, or genesis hash, so a signed spork for one network could verify on another.Description
GetSporkSignatureMessage(const CSporkMessage&)that composes a domain-separated signing string includingParams().NetworkIDString(),Params().MessageStart()(hex),Params().HashGenesisBlock(), and the delimited spork fields.CSporkManager::CheckSignatureandCSporkManager::Signto useGetSporkSignatureMessageso both signing and verification operate on the same network-bound payload.obfuscationSigner.SignMessage/VerifyMessage) so the change is limited to the signed message construction.Testing
git diff --checkwhich completed successfully with no issues../autogen.shbut the command failed in this environment due to a missingaclocal, so a full autotools build/test could not be executed here.Codex Task