Harden release workflow tag handling#11
Open
NateIsern wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
${{ github.ref_name }}inside shellrunblocks.Description
.github/workflows/release.ymlto passgithub.ref_nameinto steps via an environment variableRELEASE_TAGinstead of embedding it directly inrunscripts.^v[0-9]+[.][0-9]+[.][0-9]+(-[0-9A-Za-z][0-9A-Za-z.-]*)?$at the start of each packaging step to reject malformed or malicious tag names.${{ github.ref_name }}usages in packaging commands with quoted shell variables (e.g.,PKG_DIR="faircoin-${RELEASE_TAG}-...") and quoted all generated paths and package-related variables..deb, Windows ZIP, and macOS tarball packaging steps inrelease.yml.Testing
${{ github.ref_name }}interpolation remains insiderunblocks and the check passed.git diff --checkto validate whitespace and basic diff issues which succeeded with no warnings.bash -nstyle extraction/syntax check over the workflowrunscripts to ensure the modified shell blocks are syntactically valid and the check passed.Codex Task