Limit exposed fields from getnetworkinfo to prevent metadata disclosure#19
Merged
Merged
Conversation
NateIsern
force-pushed
the
codex/fix-network-info-api-vulnerability
branch
from
June 25, 2026 19:45
e0a3f4c to
d6581e5
Compare
NateIsern
added a commit
that referenced
this pull request
Jun 25, 2026
Document the merged hardening PRs and bump version: - sanitize /api/validate-address response + input (#18) - limit /api/network-info to public fields (#19) - cap WebSocket frame size via maxPayload (#20) Note: #20's TCP-peer WS-IP change was dropped on merge (would break the per-IP WS cap behind the proxy); #16's trusted-proxy resolution is kept. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/api/network-infoendpoint previously returned the rawgetnetworkinfoRPC response, which exposes node connectivity and deployment metadata unnecessary for the UI.Description
server/lib/network-info.tswithtoPublicNetworkInfoandPublicNetworkInfothat validate and return onlyversion,subversion,protocolversion,connections, andrelayfee./api/network-infohandler inserver/index.tsto calltoPublicNetworkInfo(blockCache.getNetworkInfo(network))before responding.server/lib/network-info.test.tsregression tests asserting that sensitive fields such asnetworks,localaddresses, andwarningsare not exposed and malformed values are ignored.Testing
npm testand all tests passed (5 files, 44 tests passed).npm run typecheckand the TypeScript build/type-check completed successfully.npm test -- --runInBandinvocation failed becausevitestdoes not support the--runInBandflag, but this flag is unnecessary and the standard test run succeeded.Codex Task