Bundler Improvements#24
Conversation
There was a problem hiding this comment.
Bug: State Variable Reference Error
In the handleSubmit method, the allValid variable is referenced directly instead of this.state.allValid. This causes a ReferenceError because allValid is a component state property and not defined in the local scope.
components/CreateTaskModal.js#L69-L70
sensemaker/components/CreateTaskModal.js
Lines 69 to 70 in 721ed6c
Bug: Duplicate Method Definition Causes Callback Issues
The handleInputChange method is defined twice. The second definition, which includes an empty callback function, overrides the first, potentially causing unexpected behavior.
components/CreateTaskModal.js#L41-L51
sensemaker/components/CreateTaskModal.js
Lines 41 to 51 in 721ed6c
Bug: Modal Form Submission Handler Error
The Form in CreateTaskModal.js incorrectly references this.handlePasswordSubmit for its onSubmit handler. The correct method, this.handleSubmit, should be used instead, as handlePasswordSubmit is undefined, leading to a runtime error upon submission.
components/CreateTaskModal.js#L110-L111
sensemaker/components/CreateTaskModal.js
Lines 110 to 111 in 721ed6c
Bug: State Update Fails Due to Typo
Typo in componentDidUpdate: filtereDocuments is used instead of filteredDocuments when updating state, preventing the correct filteredDocuments array from being updated.
components/DocumentHome.js#L76-L77
sensemaker/components/DocumentHome.js
Lines 76 to 77 in 721ed6c
Was this report helpful? Give feedback by reacting with 👍 or 👎
Fixes some issues with generating the browser bundle, also adds some new controls for certain document types.