Mars test case patch - #304
Merged
Merged
Conversation
…atch sat_vapor_pres.F90 declares tcmin/tcmax as INTEGER, but this test case set tcmax with a trailing '.' (350.), making it a Python float that Isca's namelist serializer writes out as 350.0. gfortran correctly rejects assigning a real literal to a declared-integer namelist variable, which FMS's check_nml_error surfaces as: FATAL from PE 0: check_nml_error in fms_mod: Unknown namelist, or mistyped namelist variable in namelist sat_vapor_pres_nml, (IOSTAT = 5010) This crashed the run before the first timestep. tcmin (set without a trailing '.', so already an int) was unaffected. Confirmed by bisecting input.nml block by block and then individual assignments within sat_vapor_pres_nml, and cross-checked against grey_mars_test_case.py, which sets tcmax as a plain int and has never hit this. This test case is commented out of the default trip_test run (for the separate, unrelated reason that its Socrates spectral files aren't included in the repo), which is presumably why this has gone unnoticed - it doesn't look like it's actually been run to completion before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix socrates_mars_test_case.py crashing at startup on tcmax type mismatch
sat_vapor_pres.F90 declares tcmin/tcmax as INTEGER, but this test case set tcmax with a trailing '.' (350.), making it a Python float that Isca's namelist serializer writes out as 350.0. gfortran correctly rejects assigning a real literal to a declared-integer namelist variable, which FMS's check_nml_error surfaces as:
FATAL from PE 0: check_nml_error in fms_mod: Unknown namelist, or
mistyped namelist variable in namelist sat_vapor_pres_nml, (IOSTAT = 5010)
This crashed the run before the first timestep. tcmin (set without a trailing '.', so already an int) was unaffected. Confirmed by bisecting input.nml block by block and then individual assignments within sat_vapor_pres_nml, and cross-checked against grey_mars_test_case.py, which sets tcmax as a plain int and has never hit this.
This test case is commented out of the default trip_test run (for the separate, unrelated reason that its Socrates spectral files aren't included in the repo), which is presumably why this has gone unnoticed - it doesn't look like it's actually been run to completion before.