build: force the surjectionproof CMake option - #1580
Open
Abdullah1738 wants to merge 1 commit into
Open
Conversation
Member
|
ACK 68affce tested locally. |
tomt1664
self-requested a review
August 12, 2026 13:39
tomt1664
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Elements wrapper currently forces
SECP256K1_ENABLE_MODULE_SURJECTION, but the vendored secp256k1 subtree definesSECP256K1_ENABLE_MODULE_SURJECTIONPROOF. This leaves surjection proof support enabled only by the dependency default and lets an external cache value disable it.