Skip to content

Fix blank page in X in-app browser #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xaelophone merged 1 commit into from
Feb 24, 2026
Merged

Fix blank page in X in-app browser #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@
<script>
// Prevent theme flash — apply saved theme before first paint
(function () {
var t = localStorage.getItem('hermes-theme');
if (t && t !== 'light') document.documentElement.setAttribute('data-theme', t);
try {
var t = localStorage.getItem('hermes-theme');
if (t && t !== 'light') document.documentElement.setAttribute('data-theme', t);
} catch(e) { /* localStorage blocked (in-app browsers) */ }
})();
</script>
<!-- Analytics script removed for open source -->
Expand Down
8 changes: 5 additions & 3 deletions apps/web/src/lib/supabase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@ import { IS_TAURI } from './platform';
const INIT_FLAG = '__hermes_api_initialized__';

// In-app browsers (Twitter, Instagram, etc.) can block localStorage/sessionStorage.
// Fall back to an in-memory store so the app still renders.
function safeStorage(storage) {
// Some block the property access itself (throws on `window.localStorage`), others
// allow access but throw on setItem/getItem. Handle both cases.
function safeStorage(type) {
try {
const storage = type === 'session' ? window.sessionStorage : window.localStorage;
const key = '__hermes_storage_test__';
storage.setItem(key, '1');
storage.removeItem(key);
Expand All @@ -33,7 +35,7 @@ function safeStorage(storage) {
export async function initWebApi() {
if (globalThis[INIT_FLAG]) return;

let authStorage = safeStorage(localStorage);
let authStorage = safeStorage('local');
let detectSessionInUrl = true;

if (IS_TAURI) {
Expand Down
Loading