Skip to content

Remove deprecated BlockCypher adapter and Alchemy servers - #1062

Open
j0ntz wants to merge 1 commit into
masterfrom
jon/remove-blockcypher-alchemy
Open

Remove deprecated BlockCypher adapter and Alchemy servers#1062
j0ntz wants to merge 1 commit into
masterfrom
jon/remove-blockcypher-alchemy

Conversation

@j0ntz

@j0ntz j0ntz commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

Remove the deprecated BlockCypher network adapter and the deprecated Alchemy RPC server endpoints, which were triggering irrelevant errors.

  • BlockCypher was a broadcast-only fallback adapter for Ethereum. Its adapter (BlockcypherAdapter), the case 'blockcypher' in makeNetworkAdapter, the BlockcypherAdapterConfig union member, the 'blockcypher' value in asNetworkAdaptorConfigType, the blockcypherApiKey init option, and the { type: 'blockcypher', ... } config in ethereumInfo are all removed. ETH broadcast continues to work through the remaining RPC adapter.
  • Alchemy RPC endpoints (eth-mainnet.g.alchemy.com in ethereumInfo, eth-holesky.g.alchemy.com in holeskyInfo) are removed from the RPC server lists. The Ethereum mainnet RPC list keeps 9 other servers; sync and broadcast are unaffected.
  • The now-unused alchemyApiKey init option (Ethereum and Solana) and the commented-out Solana Alchemy endpoint are also removed. Edge cleaners silently strip unknown keys, so the gui passing these keys is harmless.

The matching test fixture (currencyInfoFixture) is updated to drop the BlockCypher adapter entry so the discriminated-union exhaustiveness holds.

Linked Asana task: https://app.asana.com/0/0/1212369205065499

Testing

  • tsc clean on the changed files (the pre-existing repo-wide tsc errors in monero/bip32/walletSettings come from local node_modules drift and are identical on master).
  • Ethereum network unit tests pass (13/13), including the processEvmScanTransaction cases that build the engine adapters from the updated fixture.
  • iOS sim (edge-funds): built the gui with the modified plugin linked and opened the Ethereum mainnet wallet "My Ether 2". Balance synced (0.000000302695953 ETH) and transaction history loaded (Swap Funds, Received Ethereum) via the remaining RPC/evmscan adapters, confirming ETH functionality after the removal. Proof screenshots attached.

Note

Low Risk
Provider and config cleanup only; sync and broadcast rely on remaining adapters, with no auth or data-model changes.

Overview
Cleans up deprecated Ethereum network providers that were still configured but only produced noise in logs.

The BlockCypher broadcast-only adapter is removed end-to-end (BlockcypherAdapter, 'blockcypher' adapter type, blockcypherApiKey, and the mainnet BlockCypher config entry). ETH broadcast continues through the existing RPC (and other) adapters.

Alchemy RPC URLs are dropped from Ethereum mainnet and Holesky server lists, and alchemyApiKey is removed from Ethereum and Solana init-option cleaners (plus a commented Solana Alchemy archival URL). The Ethereum test currencyInfoFixture is updated so adapter config types stay exhaustive.

CHANGELOG records the change under Unreleased.

Reviewed by Cursor Bugbot for commit a5f8fa9. Bugbot is set up for automated code reviews on this repo. Configure here.

@j0ntz

j0ntz commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

📸 Test evidence — ETH wallet synced after removal

agent proof 1212369205065499 01 eth wallet balance synced

agent proof 1212369205065499 01 eth wallet balance synced

agent proof 1212369205065499 02 eth transactions synced

agent proof 1212369205065499 02 eth transactions synced

agent proof 1212369205065499 03 eth wallets list synced

agent proof 1212369205065499 03 eth wallets list synced

Captured by the agent's in-app test run (build-and-test).

BlockCypher was a broadcast-only fallback adapter and the Alchemy RPC
endpoints required an API key template; both were deprecated and
triggering irrelevant errors. ETH broadcast/sync continues to work via
the remaining RPC adapter and other server paths. Also drops the now
unused alchemyApiKey/blockcypherApiKey init options and the commented
Solana Alchemy endpoint.
@j0ntz
j0ntz force-pushed the jon/remove-blockcypher-alchemy branch from 2afbfb2 to a5f8fa9 Compare June 25, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant