Skip to content

ctsm5.4.049: Fix typo, 'expontential' --> 'exponential' in fates c starvation model#4093

Open
r-ward wants to merge 5 commits into
ESCOMP:masterfrom
r-ward:fix_cstarv_model_typo
Open

ctsm5.4.049: Fix typo, 'expontential' --> 'exponential' in fates c starvation model#4093
r-ward wants to merge 5 commits into
ESCOMP:masterfrom
r-ward:fix_cstarv_model_typo

Conversation

@r-ward

@r-ward r-ward commented Jun 12, 2026

Copy link
Copy Markdown

… namelist settings

Description of changes

Fixes a typo in src/utils/clmfates_interfaceMod.F90 for the fates c starvation namelist option ("expontential" --> "exponential") that causes runs using fates_cstarvation_model=exponential (valid options =linear, exponential) to abort at init with error message "Invalid carbon starvation model".

Specific notes

Contributors other than yourself, if any:

  • None

CTSM issues resolved or otherwise addressed, if any:

  • None

Any user interface changes (namelist or namelist defaults changes)?
None, this makes the already valid exponential fates c starvation model functional

Testing planned or performed, if any:

  • tested with single point FATES run at BCI, Panama on Derecho; fix allows running with fates_cstarvation_model=exponential on ctsm5.3.077, PR branch is on current master because change is a single character typo fix, outcome should be identical

Requirements before merge:

  • The code in this PR branch builds with no errors. (one-character string-literal change; identical fix built and run on Derecho; ctsm5.3.077)
  • The code in this PR branch runs with no errors. Briefly describe tested configuration(s): tested on ctsm5.3.077
  • This either (a) does not change answers, (b) it only changes answers at roundoff level, or (c) I have performed a scientific evaluation of the answer changes. Which?: (a) does not change answers, allows fates_cstarvation_model=exponential configuration to function
  • I have reviewed relevant parts of the CLM documentation Tech Note or User's Guide to determine if anything needs to be changed or added. If it does, describe:
  • This PR either (a) does not create a need to update the documentation or (b) includes required documentation updates (see guidelines for contributing documentation). Which?:(a)

@samsrabin samsrabin added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jun 17, 2026
@samsrabin

Copy link
Copy Markdown
Member

Good catch! @glemieux will handle this, including adding a test.

@samsrabin samsrabin added bug something is working incorrectly test: fates Pass fates test suite before merging and removed next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Jul 2, 2026
@samsrabin
samsrabin requested a review from glemieux July 2, 2026 16:28
@glemieux

glemieux commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Thanks for making this @r-ward! I've made a PR to this branch to bring in the tests: r-ward#2

@glemieux glemieux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r-ward#2 to be integrated first

Add testing for FATES carbon starvation mode
@wwieder

wwieder commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@slevis-lmwg can you bring this in?

@github-project-automation github-project-automation Bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Jul 21, 2026
@github-project-automation github-project-automation Bot moved this from Ready to start (or start again) to In progress - master in CTSM: Upcoming tags Jul 21, 2026
@slevis-lmwg slevis-lmwg changed the title Fix typo, 'expontential' --> 'exponential' in fates c starvation model… ctsm5.4.0xx: Fix typo, 'expontential' --> 'exponential' in fates c starvation model Jul 21, 2026
@slevis-lmwg slevis-lmwg moved this from Todo to In Progress in LMWG: Sprint Planning Board Jul 21, 2026
@slevis-lmwg slevis-lmwg changed the title ctsm5.4.0xx: Fix typo, 'expontential' --> 'exponential' in fates c starvation model ctsm5.4.049: Fix typo, 'expontential' --> 'exponential' in fates c starvation model Jul 23, 2026
@slevis-lmwg

Copy link
Copy Markdown
Contributor

@slevis-lmwg note to self: After the b4b-dev merge (.048)

  • run the aux_clm and
  • fates test suites
  • and merge

@slevis-lmwg slevis-lmwg moved this from In Progress to Stalled in LMWG: Sprint Planning Board Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something is working incorrectly test: fates Pass fates test suite before merging

Projects

Status: In progress - master
Status: Stalled

Development

Successfully merging this pull request may close these issues.

5 participants