Skip to content

Review of Docs 2.29. Dynamic Global Vegetation and FATES#4037

Open
adrifoster wants to merge 12 commits into
ESCOMP:b4b-devfrom
adrifoster:fates_review
Open

Review of Docs 2.29. Dynamic Global Vegetation and FATES#4037
adrifoster wants to merge 12 commits into
ESCOMP:b4b-devfrom
adrifoster:fates_review

Conversation

@adrifoster

Copy link
Copy Markdown
Contributor

Description of changes

Review of Tech Note section 2.29: Dynamic Global Vegetation and FATES

Specific notes

Added a section on reduced complexity modes and supported configurations.

Contributors other than yourself, if any: @wwieder

CTSM issues resolved or otherwise addressed, if any: Resolves #3875

Requirements before merge:

@samsrabin samsrabin linked an issue May 21, 2026 that may be closed by this pull request
8 tasks
@samsrabin samsrabin moved this to In review in CLM documentation May 21, 2026
@samsrabin samsrabin added documentation additions or edits to user-facing documentation or its infrastructure b4b bit-for-bit PR status: awaiting review Work on this PR is paused while waiting for review. docs:update Significant update or fix needed to existing documentation docs-loc:tech-note Relates to Technical Note (science) labels May 21, 2026
@samsrabin samsrabin assigned wwieder and unassigned wwieder May 21, 2026
@samsrabin
samsrabin requested a review from wwieder May 21, 2026 16:09

@wwieder wwieder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might encourage a few more citations of more recent FATES papers and a quick summary of how CLM-FATES is different than vanilla CLM could be helpful, but otherwise this looks good. I'll approve this but happy to take another look if needed.

Comment thread doc/source/tech_note/DGVM/CLM50_Tech_Note_DGVM.rst Outdated
Comment thread doc/source/tech_note/DGVM/CLM50_Tech_Note_DGVM.rst Outdated
Comment thread doc/source/tech_note/DGVM/CLM50_Tech_Note_DGVM.rst Outdated
Comment thread doc/source/tech_note/DGVM/CLM50_Tech_Note_DGVM.rst Outdated
Comment thread doc/source/tech_note/DGVM/CLM50_Tech_Note_DGVM.rst Outdated
Comment thread doc/source/tech_note/DGVM/CLM50_Tech_Note_DGVM.rst Outdated
@adrifoster

Copy link
Copy Markdown
Contributor Author

Thanks for the suggestions @wwieder. I made all the updates you suggested, please take a look and see what you think.

@slevis-lmwg

Copy link
Copy Markdown
Contributor

Thanks for the suggestions @wwieder. I made all the updates you suggested, please take a look and see what you think.

@adrifoster I can do the final review and let @wwieder off the hook :-)

@slevis-lmwg
slevis-lmwg self-requested a review July 24, 2026 21:05

@slevis-lmwg slevis-lmwg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrifoster thank you for getting this ready and @wwieder thank you for the first review. I have minor corrections to contribute, and I can push them easily myself :-)

Comment thread doc/source/tech_note/FATES/CLM50_Tech_Note_FATES.rst Outdated
Comment thread doc/source/tech_note/FATES/CLM50_Tech_Note_FATES.rst Outdated
Comment thread doc/source/tech_note/FATES/CLM50_Tech_Note_FATES.rst Outdated
Adding :ref: in front of Foster et al. for the link to work
Made the boldface section consistent in (1) as in (2) and (3)
@github-actions

This comment was marked as resolved.

Replace option 2 with carbon_nitrogen and 1 with carbon_only
@github-actions

This comment was marked as resolved.

1 similar comment
@github-actions

This comment was marked as resolved.

@slevis-lmwg

Copy link
Copy Markdown
Contributor

I will work on correcting the build-fail.

@github-actions

This comment was marked as resolved.

Comment thread doc/source/tech_note/References/CLM50_Tech_Note_References.rst Outdated
Update from curly to not curly quotes for References section to build
@slevis-lmwg

Copy link
Copy Markdown
Contributor

@adrifoster this is ready to merge as far as I am concerned, but I will let you make the final decision.

@slevis-lmwg slevis-lmwg removed the PR status: awaiting review Work on this PR is paused while waiting for review. label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit docs:update Significant update or fix needed to existing documentation docs-loc:tech-note Relates to Technical Note (science) documentation additions or edits to user-facing documentation or its infrastructure

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Technote: Add FATES-CN paragraph to 2.29. Dynamic Global Vegetation and FATES Review 2.29. Dynamic Global Vegetation and FATES

4 participants