fix: return the correct attribute count on partial attribute-list responses#597
Open
MrAlaskan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the attribute count returned by
GetAttributeList()andSetAttributeList()when the response is truncated withPartialTransfer.Problem
Both
GetAttributeList()andSetAttributeList()reserve space for the attribute count field at the beginning of the response and later backfill it after processing the requested attributes. However, when either service detects that the remaining response buffer is too small and returnskCipErrorPartialTransfer, it currently writes backattribute_count_request, which is the number of attributes requested by the client.This is incorrect for a partial response. In a
PartialTransfercase, the attribute count field must describe the number of attribute entries that were actually written into the response, not the total number that were requested. The current implementation therefore produces a response whose declared attribute count can be larger than the number of attribute status entries that actually follow in the payload.This creates a protocol-format mismatch and can cause clients or conformance tools to misparse the response or reject it as invalid.
Changes
GetAttributeList()andSetAttributeList().