fix: set explicit connection watchdog timeout action to AutoDelete#596
Open
MrAlaskan wants to merge 1 commit into
Open
fix: set explicit connection watchdog timeout action to AutoDelete#596MrAlaskan wants to merge 1 commit into
MrAlaskan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes explicit messaging connections expose the correct default watchdog timeout action after they are established.
Problem
For explicit messaging connections, the default watchdog timeout action is
AutoDelete. However,EstablishClass3Connection()currently deep-copies the parsed connection object, appliesConnectionObjectGeneralConfiguration(), and then adds the connection to the active list without updating the watchdog timeout action for the explicit connection case.ConnectionObjectGeneralConfiguration()initializeswatchdog_timeout_actiontoInvalid, and there is no later path that corrects the value for class 3 connections. As a result, the connection object can remain externally observable withAttribute 12set toInvalideven though the actual timeout behavior is implemented throughClass3ConnectionTimeoutHandler(), which deletes the connection on timeout.This creates a mismatch between the exposed connection object state and the runtime timeout behavior for explicit messaging connections.
Changes
watchdog_timeout_actiontokConnectionObjectWatchdogTimeoutActionAutoDeleteinEstablishClass3Connection()after the generic connection object configuration step.