OK 7B87B0 - #60
Open
Drahsid wants to merge 2 commits into
Open
Conversation
queueRAM
approved these changes
Jul 29, 2026
queueRAM
left a comment
queueRAM
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Just had a couple suggestions, assuming it still matches.
Co-Authored-By: queueRAM <129774+queueRAM@users.noreply.github.com>
Drahsid
force-pushed
the
OK_overlay3_7B87B0
branch
from
July 29, 2026 01:40
df30c9c to
520366d
Compare
queueRAM
reviewed
Jul 29, 2026
|
|
||
| // actor 0 is always the main character, Marina | ||
| #define gPlayerActor gActors[PLAYER_INDEX] | ||
| #define gPPlayerActor (gActors) |
Contributor
There was a problem hiding this comment.
What's the intended purpose of the addition of gPPlayerActor?
Owner
Author
There was a problem hiding this comment.
line 544 7B87B0.c requires gActors-> to match.
Contributor
There was a problem hiding this comment.
Got it, so gPPlayerActor is just providing a more meaningful name than gActors in those instances
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
another overlay 3 file