fix: resolve critical bugs across notebooks - #2
Open
belowzeroff wants to merge 1 commit into
Open
Conversation
- Fix os.remove('{filepath}') string literal bug (used quotes around variable)
- Fix class_mode='binary' to 'categorical' for 4-class classification
- Fix Dense(2048) output layer to Dense(4) for 4 classes
- Fix plt undefined NameError by using correct plot alias
- Fix ax undefined NameError by switching to pyplot interface
- Fix deprecated DataFrame.append() to pd.concat()
- Fix aadd_texts coroutine never awaited (added await)
- Fix foo3 copy-paste error (used texts1 instead of texts4)
- Add .gitignore to exclude .maestri and generated files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critical Bug Fixes
This PR fixes critical and major bugs found across the project codebase.
Image Search
os.remove("{filepath}")used a string literal instead of the variablefilepath— files were never actually deletedclass_mode="binary"used for 4-class classification — changed to"categorical"Dense(2048, activation='softmax')for 4 classes — changed toDense(4, activation='softmax')Time Series
plotbut later usedplt— fixed alias consistencyax.set_ylabel()without creatingax— switched to pyplot equivalentspd.concat()(removed in pandas 2.0)TorQBot
foo3usedtexts1instead oftexts4Project Config
.gitignoreto exclude.maestri, checkpoints, cache, and generated files