Skip to content

Improvement: Introduce Mac OS Github Workflow - #2378

Merged
sandro-elsweijer merged 4 commits into
mainfrom
impr_macos_workflow_clean
Jul 28, 2026
Merged

Improvement: Introduce Mac OS Github Workflow#2378
sandro-elsweijer merged 4 commits into
mainfrom
impr_macos_workflow_clean

Conversation

@spenke91

Copy link
Copy Markdown
Collaborator

Describe your changes here:

Closes #2201. Replaces #2252, which just has too many trial-and-error commits to ever be merged :-)

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • README.md files are updated if necessary.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the scripts/internal/find_all_source_files.sh to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.28%. Comparing base (f63e8b8) to head (7d54047).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2378   +/-   ##
=======================================
  Coverage   82.28%   82.28%           
=======================================
  Files         125      125           
  Lines       20701    20701           
=======================================
  Hits        17033    17033           
  Misses       3668     3668           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spenke91 spenke91 mentioned this pull request Jul 27, 2026
17 tasks
@sandro-elsweijer
sandro-elsweijer self-requested a review July 27, 2026 14:57
@sandro-elsweijer sandro-elsweijer self-assigned this Jul 27, 2026

@sandro-elsweijer sandro-elsweijer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only minor things

Comment thread .github/workflows/test_t8code_macos.yml Outdated
Comment thread .github/workflows/test_t8code_macos.yml Outdated
Comment thread .github/workflows/test_t8code_macos.yml Outdated
Comment thread .github/workflows/test_t8code_macos.yml Outdated
Comment thread .github/workflows/test_t8code_macos.yml Outdated
Comment thread .github/workflows/test_t8code_macos.yml
spenke91 and others added 2 commits July 28, 2026 10:33
Direct suggestions

Co-authored-by: Sandro Elsweijer <49643115+sandro-elsweijer@users.noreply.github.com>
@spenke91

Copy link
Copy Markdown
Collaborator Author

Thanks a lot for your review @sandro-elsweijer, I updated the PR accordingly 👍

@sandro-elsweijer sandro-elsweijer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sandro-elsweijer
sandro-elsweijer added this pull request to the merge queue Jul 28, 2026
Merged via the queue into main with commit ade5ac6 Jul 28, 2026
41 checks passed
@sandro-elsweijer
sandro-elsweijer deleted the impr_macos_workflow_clean branch July 28, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WIP: Run CI-Pipeline on MacOS

2 participants