fix(urn): converge DIG URN parsing onto the cross-repo grammar - #16
Draft
MichaelTaylor3d wants to merge 2 commits into
Draft
fix(urn): converge DIG URN parsing onto the cross-repo grammar#16MichaelTaylor3d wants to merge 2 commits into
MichaelTaylor3d wants to merge 2 commits into
Conversation
Both assets/dig-embed.js parseDigRef and assets/sw.js parseDigUrn derived resource keys and salts that disagreed with the ecosystem's other DIG URN parsers, so the same URN produced a different retrieval key or a different content-decryption key here than in dig-sdk, the extension or the hub — content that does not resolve. Verified against the shared conformance table shipped in @dignetwork/dig-sdk, read as a devDependency rather than copied (a copied table drifts). Rule: SYSTEM.md § "DIG URN grammar (normative, cross-repo)". refs DIG-Network/dig_ecosystem#2725
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE — gate round in progress
WIP. Converges this repo's DIG URN parsing onto the normative rule in the superproject
SYSTEM.md§ "DIG URN grammar (normative, cross-repo)", verified against the shared conformancetable shipped in
@dignetwork/dig-sdk/conformance/urn-parse.json(read as a devDependency — nevercopied into this repo).
refs DIG-Network/dig_ecosystem#2725