ci: pin dig-dns version to 0.15.1 - #70
Conversation
Update DIG_DNS_VERSION from 0.9.1 to 0.15.1 in the installer e2e workflow. The v0.9.1 release does not include the digd binary, which is now required by the default component set. The v0.15.1 release includes both dig-dns and digd binaries with matching asset naming conventions (digd-0.15.1-<platform>). Closes DIG-Network/dig_ecosystem#2796 Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Correcting this PR's stated justification — the fix is right, the reasoning in the description is notThe description says the v0.9.1 pin was non-working and that the e2e "would error on the hard count The reason is visible at It asserts the PLAN, not a download. The fix is still correct, for the original reason rather than the claimed oneThe pin carries a deliberate rationale at
That was true when written. It is not true now:
So this is a stale deliberate pin, not a broken one — and the comment explaining it must be updated The secondary finding, which is the more useful oneThe e2e cannot catch this class. Its default-component check asserts what the installer plans to That is worth its own ticket in dig-installer rather than expanding this PR — but it should be recorded, |
The 0.44.0 -> 0.44.1 bump updated the root Cargo.lock but not
gui/app/src-tauri/Cargo.lock, which carries its own entry for the
dig-installer package. Every `gui *` job runs cargo with --locked
against that second workspace, so all five of them failed with:
error: cannot update the lock file .../gui/app/src-tauri/Cargo.lock
because --locked was passed to prevent this
Verified with `cargo metadata --manifest-path gui/app/src-tauri/Cargo.toml
--locked`, which now resolves offline.
Co-Authored-By: Claude <noreply@anthropic.com>
Gate: PASS (single correctness gate — mechanical, behaviour-preserving)Tier per §1.10: this is a workflow env pin plus a lockfile re-lock. No custody, crypto, or wire surface, so one correctness gate rather than the triple. The pin is correct, measured against the actual releases
The old pin's own comment cited dig_ecosystem#525 as the reason to stay on 0.9.1; that issue is closed, and 0.9.1 genuinely has no Why five
|
Summary
Updates dig-dns version pin from 0.9.1 to 0.15.1 in the installer e2e workflow.
The v0.9.1 release does not include the
digdbinary, which is required by the installer's default component set (verified in the test at line 1127). The v0.15.1 release includes bothdig-dnsanddigdbinaries.Asset comparison
v0.9.1 assets:
v0.15.1 assets:
Filename construction compatibility
The installer's release.rs uses the stem
"digd"to match assets nameddigd-<ver>-<os_arch>[.exe]. Both v0.9.1 and v0.15.1 use matching conventions, but v0.9.1 has nodigdassets while v0.15.1 does.Previous workflow status
The e2e test (line 1127) explicitly checks for the presence of a
digdbinary in the default plan, making v0.9.1 a non-passing pin for the current test suite. This update restores a working pin.Closes https://github.com/DIG-Network/dig_ecosystem/issues/2796