chore(deps): bump github.com/fxamacker/cbor/v2 to v2.5.0#50
Open
moralpriest wants to merge 1 commit into
Open
Conversation
Vendored dependency bump (prep for eventual Go toolchain bump). - github.com/fxamacker/cbor/v2: v2.5.0 (go 1.12, latest go<=1.17). Used by p2p (chunk_server, rpc_cbor_codec) and rpc packages for CBOR encoding. Note: vendored at vendor/github.com/fxamacker/cbor/v2 (the /v2 major-version suffix must stay in the import path). Verification: - go build ./... green. - go test ./...: cbor's own suite and the p2p/rpc importers pass. Only pre-existing failure is Test_Payload_TX (walletapi, reproduced on clean community-dev). - derod --testnet starts, logs cleanly (no errors/panics).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vendored dependency bump (prep for eventual Go toolchain bump).
p2p(chunk_server, rpc_cbor_codec) andrpcfor CBOR encoding.Solo PR (per review: encoding split from storage). All
go <= 1.17— clean standalone.Verification
go build ./...green (vendored atvendor/github.com/fxamacker/cbor/v2— the/v2major-version suffix stays in the import path).go test ./...: cbor's own suite and the p2p/rpc importers both pass. Only pre-existing failure isTest_Payload_TX(walletapi, reproduced identically on clean community-dev).derod --testnetstarts, logs cleanly (no errors/panics).Follow-ups
Remaining go<=1.17 vendored-dep candidates: metrics (VictoriaMetrics+histogram), env, go-colorful, pkg/profile, kcp-go, robfig/cron. (cespare/xxhash deferred as consensus-critical; tjfoc/gmsm unused; blang/semver + go.uber.org/atomic already at latest; go-logr/zapr deferred until logr v1.2.4 / PR #46 lands.)