chore(deps): bump go.uber.org/zap to v1.21.0 and multierr to v1.8.0#47
Open
moralpriest wants to merge 1 commit into
Open
Conversation
Vendored dependency bumps (prep for eventual Go toolchain bump). - go.uber.org/zap: v1.21.0 (go 1.13, was v1.13-era). Concrete logging backend behind the logr/zapr adapter. - go.uber.org/multierr: v1.8.0 (go 1.14, latest go<=1.17). zap dependency. - go.uber.org/atomic intentionally NOT bumped: already at v1.9.0 (latest go<=1.17) — verified byte-identical (no-op). Verification: - go build ./... green - go test ./globals/... pass (exercises globals.go:182 zapr.NewLogger wiring) - go vet ./... clean (only pre-existing unkeyed-field warnings in dvm tests) - derod --testnet starts and logs via zap backend (CORE/MEMPOOL/REGPOOL) - run_integration_test.sh: only pre-existing failure (lottery_within_block_1panic_1success_test) reproduced identically on clean community-dev worktree — not a regression. Note: go-logr/zapr v1.2.4 deferred to a follow-up PR because it requires logr v1.2.4 (PR DEROFDN#46), which is not yet merged into community-dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vendored dependency bumps (prep for eventual Go toolchain bump). Bumps the logging backend stack:
globals/globals.go:182zapr.NewLogger(zcore)).Why this is safe
go <= 1.17(our directive) — clean standalone PRs, no go-directive bump.Verification
go build ./...— green (exit 0).go test ./globals/...— pass (exercisesglobals.go:182zapr.NewLogger wiring + logger recovery).go vet ./...— clean (only pre-existingunkeyed fieldswarnings indvm/simulator_test.go, unrelated).derod --testnetstarts and logs via the zap backend (CORE/MEMPOOL/REGPOOL emit correctly).run_integration_test.sh: the single failure (lottery_within_block_1panic_1success_test) is pre-existing — reproduced identically on a clean community-dev worktree. SC lottery logic, unrelated to a logging-backend bump.Follow-ups