Feat/df 1242: Enable Welsh translation for 'form unavailable' page - #455
Merged
Conversation
davidjamesstone
approved these changes
Aug 7, 2026
davidjamesstone
left a comment
davidjamesstone
left a comment
Contributor
There was a problem hiding this comment.
LGTM Jez - just that 1 query from me.
| instructionSummary: t('components.locationFieldBase.howToFind'), | ||
| instructionText: | ||
| tComponent(component.def, 'instructionText') || | ||
| component.options.instructionText, |
Contributor
There was a problem hiding this comment.
Why the fallback here? Will tComponent not already fallback to the English version?
Contributor
Author
There was a problem hiding this comment.
Yes, it's overkill. I'll remove
jbarnsley10
enabled auto-merge
August 7, 2026 12:32
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Enable Welsh translation for 'form unavailable' page
Jira ticket: DF-1242
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).