Skip to content

fix: cleanup & update instrument data #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunfang98927 merged 1 commit into from
Jul 15, 2025
Merged

fix: cleanup & update instrument data #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ python manage.py migrate

## Loading Data

At present, UMIL supports an initial list of 262 instruments curated from Wikidata, and their names in English and French. These instruments can be found in `web-app/django/startup_data/vim_instruments_with_images-15Sept.csv`.
At present, UMIL supports an initial list of 262 instruments curated from Wikidata, and their names in English and French. These instruments can be found in `web-app/django/startup_data/umil_instruments_15July_2025.csv`.

Two django management commands are provided to load these initial instruments. These should be run from within the app Docker container by going into its shell.

Expand Down
2 changes: 1 addition & 1 deletion web-app/django/VIM/apps/instruments/management/commands/download_imgs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class Command(BaseCommand):
OUTPUT_DIR = os.path.join(
settings.STATIC_ROOT, "instruments", "images", "instrument_imgs"
)
CSV_PATH = "startup_data/all_instruments_16aug_2024.csv"
CSV_PATH = "startup_data/umil_instruments_15July_2025.csv"

help = "Download images and create thumbnails for instruments"

Expand Down
4 changes: 2 additions & 2 deletions web-app/django/VIM/apps/instruments/management/commands/import_instruments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class Command(BaseCommand):

NOTE: For now, this script only imports instrument names in English and French. It
also only imports a set of previously-curated instruments that have images available.
This list of instruments is stored in startup_data/vim_instruments_with_images-15sept.csv
This list of instruments is stored in startup_data/umil_instruments_15July_2025.csv
"""

help = "Imports instrument objects"
Expand Down Expand Up @@ -130,7 +130,7 @@ def create_database_objects(

def handle(self, *args, **options) -> None:
with open(
"startup_data/all_instruments_16aug_2024.csv",
"startup_data/umil_instruments_15July_2025.csv",
encoding="utf-8-sig",
) as csvfile:
reader = csv.DictReader(csvfile)
Expand Down
Loading