fix: rebuild Your files from GitHub on dashboard load - #146
Draft
kyuchia wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
"Your files" are rendered from a local PouchDB tree. Saves dual-write (GitHub + tree), but nothing ever rebuilds the tree from GitHub, so after clearing browser data or switching devices, the panel shows empty while the user's
cress-mappingsrepo is intact. Pre-existing gap in the #140 storage layer, not a regression.Fix
Background reconcile on dashboard load, GitHub as source of truth:
listRemoteMappings()(remote-only names, no-op when logged out) +reconcileTreeWithRemote(), paints the local tree first, then materializes any remote mapping not found anywhere in the tree (reusesmaterializeCopyInTree, idempotent).Additive-only for v1: local-only entries are never deleted; no dirty/unsynced marker exists yet, so deletion could destroy an unsynced file. Deletion-side reconcile is a follow-up. Failures are non-fatal (console.warn, local tree stays usable).
Testing (local, manual)
Fresh incognito + login → all repo files appear in ~1–2s (previously empty); editor content matches GitHub. Hard refresh → no duplicates. Saving new mappings and All Mappings unaffected. Logged out → silent no-op.
Notes
Stacked on #145 (merge order: #140 → #141 → #145 → this); this PR's own commits are
6a003ad+eb09b09. ThePouchDbLocalStore: 2 documents named ...console message is the pre-existing mirror-orphan issue, unrelated.