Skip to content

MTL-1497 add shellcheck - #49

Open
jacobsalmela wants to merge 3 commits into
masterfrom
add-shellcheck
Open

MTL-1497 add shellcheck#49
jacobsalmela wants to merge 3 commits into
masterfrom
add-shellcheck

Conversation

@jacobsalmela

Copy link
Copy Markdown

Signed-off-by: Jacob Salmela jacob.salmela@hpe.com

Summary and Scope

  • Partially implements MTL-1497

This adds a shellcheck Action. It's set to fail on warnings or errors. As a starting point, I disabled the existing warnings and any future scripts will need to pass this gate.

Issue Type
  • RFE Pull Request

Adds shellcheck workflow to this repo.

Prerequisites

  • I have included documentation in my PR (or it is not required)
  • I tested this on internal system (x) (if yes, please include results or a description of the test)

Idempotency

N/A

Risks and Mitigations

Low

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@jacobsalmela jacobsalmela self-assigned this May 9, 2022
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
@jacobsalmela
jacobsalmela marked this pull request as ready for review May 9, 2022 13:12
@jacobsalmela
jacobsalmela requested a review from a team as a code owner May 9, 2022 13:12
@med-hpe

med-hpe commented May 9, 2022

Copy link
Copy Markdown

Why the MIT License updates (which seem unrelated). Does shellcheck require such?

@jacobsalmela

Copy link
Copy Markdown
Author

The HPE license checker fails if a file does not have it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants