Skip to content

Component/branches dropdown menu - #43

Open
josephjophy wants to merge 2 commits into
mainfrom
component/BranchesDropdownMenu
Open

Component/branches dropdown menu#43
josephjophy wants to merge 2 commits into
mainfrom
component/BranchesDropdownMenu

Conversation

@josephjophy

@josephjophy josephjophy commented Nov 7, 2023

Copy link
Copy Markdown
Member

Added branches dropdown menu feature.

@Brodypen Brodypen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work so far

find a good svg image you can use for the drop down.
Address the comment to fix alignment

Deal with merge conflict or let me know if you need help.

Comment thread components/NavBar.tsx
<Link href="/gallery">Gallery</Link>
</li>
<li
className="relative flex items-center"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete flex and items-center from this line, what does this do?

With flex and items-center, "branches" wont be in align with the rest of the navbar. How can we make branches appear on the right without messing up how branches appear?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants