fix(coverage): restore validated npm workspace lock owners - #748
Draft
seonghobae wants to merge 60 commits into
Draft
fix(coverage): restore validated npm workspace lock owners#748seonghobae wants to merge 60 commits into
seonghobae wants to merge 60 commits into
Conversation
The exact #703 merge tree failed the existing workflow contract because CodeQL init/analyze remained at v4.37.0 while upload-sarif used v4.37.4. Align both central CodeQL workflows to the already-vetted immutable v4.37.4 SHA so the npm workspace resolver can be measured by the full repository coverage gate instead of failing on an unrelated protected-base defect.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restore the fail-closed npm workspace lock-owner resolver and its central OpenCode coverage integration in a clean replacement for closed #703.
A selected nested package such as
apps/desktopcan install from its nearest validated workspace owner instead of requiring an invalid duplicate lockfile beside every workspace package.Root cause
BandScope owns one root npm workspace lock for
apps/*andpackages/*. The central coverage path selectedapps/desktop, attempted an isolated installation inside that directory, failed to materialize Vitest, and converted infrastructure incompleteness intoREQUEST_CHANGESon otherwise valid product PRs.Trust boundary
packagesentry for the selected workspace;npm-shrinkwrap.jsonprecedence overpackage-lock.json;**/node_modules/**workspace exclusion;npm ci --workspace <selector>argv from the validated owner;--offline --ignore-scripts --no-audit --no-fundand bounded cache semantics;Verification contract
apps/desktopworkspace fixture resolves to repository root;apps/node_modulesfixture remains excluded even underapps/*, matching npm's authoritative workspace discovery;git diff --check;Standards and doctoring
docs/doctoring/npm-workspace-lock-ownership.mdrecords the central/product MSA boundary, trust model, fail-closed limitations, verification contract, and APA 7th references to the current npm CLI 12.0.2 documentation and the authoritative@npmcli/map-workspacesimplementation.Stacking and cleanup
This PR is intentionally draft until central baseline #731 merges. The branch currently retains the overlapping CodeQL/Strix baseline inherited from the former implementation history; after #731 lands, those overlapping files must be reconciled against the new protected
mainso the final diff contains only:.github/workflows/opencode-review-dispatch.ymldocs/doctoring/npm-workspace-lock-ownership.mdscripts/ci/npm_workspace_install_root.pytests/npm_workspace_test_support.pytests/test_npm_workspace_install_root.pytests/test_npm_workspace_install_root_hardening.pytests/test_opencode_agent_contract.pyThe superseded PR-specific repair workflow has already been removed. No completion or green-check claim is made before the cleaned exact head is verified.