London | 26-Java-June | Mikiyas Gebremichael | Sprint1 | Print Prime Numbers#25
Open
Mikiyas-STP wants to merge 3 commits into
Open
London | 26-Java-June | Mikiyas Gebremichael | Sprint1 | Print Prime Numbers#25Mikiyas-STP wants to merge 3 commits into
Mikiyas-STP wants to merge 3 commits into
Conversation
Mikiyas-STP
added
📅 Sprint 1
Mikiyas-STP
changed the title
jacknewman1995
approved these changes
Jul 3, 2026
| public class Main { | ||
|
|
||
| public static void main(String[] args) { | ||
| primePrinter(1000); |
There was a problem hiding this comment.
Minor point - method names are normally verbs, so 'printPrimes' or similar
Author
There was a problem hiding this comment.
corrected. minor but very useful. thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer. You must remove this section if you have no questions.