fix: use stable PR route for webview links - #75
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019fd419-4685-7716-9fc1-72028e39526a Co-authored-by: Ivan Milev <ivanmilevtues@gmail.com>
Architecture review · no architectural changesgraph LR
n_Analysis_Engine_Adapter["Analysis Engine Adapter"]
n_Visual_Rendering_Engine["Visual Rendering Engine"]
n_Structural_Diff_Engine["Structural Diff Engine"]
n_Telemetry_Feedback_Handler["Telemetry #38; Feedback Handler"]
n_Interaction_Orchestrator["Interaction Orchestrator"]
n_Analysis_Engine_Adapter -- "Passes repository context for CTA generation" --> n_Interaction_Orchestrator
n_Visual_Rendering_Engine -- "Queries for architectural changes" --> n_Structural_Diff_Engine
n_Structural_Diff_Engine -- "Provides change-set data" --> n_Visual_Rendering_Engine
n_Interaction_Orchestrator -- "Consumes issue counts for UI" --> n_Visual_Rendering_Engine
classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
Colors indicate component changes compared to target branch Download the PR analysis artifacts from this workflow artifact. Explore this PR’s architecture in your browser or VS Code. codeboarding-action · run |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec3dc33058
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| HEAD_ANALYSIS: ${{ steps.analyze.outputs.head_analysis }} | ||
| RUN_ID: ${{ github.run_id }} | ||
| CHANGED_COUNT: ${{ steps.diagram.outputs.n_changed }} |
There was a problem hiding this comment.
Preserve the run ID used by the comment footer
For every review-mode run, removing RUN_ID from this step's environment leaves the existing interpolation at action.yml:1413 unset. Because this script does not enable set -u, the step succeeds but every posted comment ends with codeboarding-action · run instead of the identifying GitHub run number; keep github.run_id available here even though the webview URL no longer needs it.
Useful? React with 👍 / 👎.
Summary
/{owner}/{repo}/pull/{pr}routeTests
python -m unittest tests.test_build_cta -vpython -m unittest discover -s tests -p 'test_*.py'(181 tests)pre-commit run --all-filesgit diff --checkhttps://app.codeboarding.org/Org/Repo/pull/9