Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,8 @@ function dataTypeReader(node: Node): Reader<unknown> {
return variantReader(node);
case "Nested":
return nestedReader(node);
case "Tuple":
return tupleReader(node);

// --- parameterized scalars ---
case "FixedString":
Expand Down Expand Up @@ -211,7 +213,9 @@ function tupleReader(node: Node): Reader<unknown> {
const readers = node.arguments.map(astToReader);
const names = node.element_names;
const named =
names.length === readers.length && names.every((n) => n.length > 0);
names.length > 0 &&
names.length === readers.length &&
names.every((n) => n.length > 0);
if (named) {
const fields: Record<string, Reader<unknown>> = {};
for (let i = 0; i < names.length; i++) fields[names[i]!] = readers[i]!;
Expand Down
21 changes: 21 additions & 0 deletions skills/clickhouse-js-node-rowbinary/tests/compile.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,4 +111,25 @@ describe("astToReader (AST -> Reader fold)", () => {
/cannot build a column reader/,
);
});

it("folds an empty Tuple to an empty array reader", () => {
const read = reader("Tuple()");
const s = new Cursor(Buffer.alloc(0));
expect(read(s)).toEqual([]);
expect(s.pos).toBe(0);
});

it("folds a nested empty Tuple", () => {
const read = reader("Tuple(Tuple())");
const s = new Cursor(Buffer.alloc(0));
expect(read(s)).toEqual([[]]);
expect(s.pos).toBe(0);
});

it("folds an empty Tuple alongside other columns", () => {
const read = reader("Tuple(Tuple(), UInt8)");
const s = new Cursor(Buffer.from([0x05]));
expect(read(s)).toEqual([[], 5]);
expect(s.pos).toBe(1);
});
});