fix/client: fastlane short description length, gradle wrapper checksum - #77
Merged
Conversation
…ecksum - short_description.txt was overwritten with a 268-char paragraph in a later commit, breaking F-Droid's 80-char limit. Restored to a short summary. - add distributionSha256Sum to gradle-wrapper.properties per the F-Droid RFP scanner report. Does not fix the wrapper jar itself (still the 7.0.2 launcher despite properties declaring 8.14.3), that needs './gradlew wrapper --gradle-version 8.14.3 --gradle-distribution-sha256-sum ...' run locally since it needs network access to Gradle's distribution servers, which this environment doesn't have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two of the three issues from the F-Droid RFP scanner report.
short_description.txthad been overwritten with a 268-char paragraph, over F-Droid's 80-char limit. Restored to a short summary.distributionSha256Sumtogradle-wrapper.properties.Not fixed here, needs to be run locally:
gradle-wrapper.jaris still the Gradle 7.0.2 launcher despitegradle-wrapper.propertiesdeclaring 8.14.3. Fix with:This needs network access to Gradle's distribution servers, which this sandbox doesn't have.
Not fixed here, lives in the separate
fdroiddatarepo: the scanner'sversionCode: 0is a static-analysis artifact (it readsAndroidManifest.xmldirectly, which never has a literal versionCode since Gradle computes it fromtauri.properties), not a bug in the app. But theBuilds:entry in the fdroiddata YAML needs to be updated to the current release (0.2.0/ versionCode2000), not the0.1.0/1000from the original draft.Authored by Claude Sonnet 5.