fix(tests): refresh CF client after container restart - #152
Merged
Conversation
Docker's ephemeral port mapping reassigns the host port whenever a container is stopped and started. The cf_client fixture captured the original port at class setup; after restart_container / start_container it pointed at a dead port, causing every wait_for_sync attempt to fail silently until the 180-second timeout expired. Recreating the client from the compose state after each CF restart picks up the new port and lets the tests pass.
|
simon-ess
reviewed
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker's ephemeral port mapping reassigns the host port whenever a container is stopped and started. The cf_client fixture captured the original port at class setup; after restart_container / start_container it pointed at a dead port, causing every wait_for_sync attempt to fail silently until the 180-second timeout expired.
Recreating the client from the compose state after each CF restart picks up the new port and lets the tests pass.