fix(validation): detect inconsistent chain values - #2467
Conversation
|
Hi @chico10117 - this PR looks stale, and review should wait because required CI is missing or has not reported for the latest head commit yet. Could you please fix CI and update the PR when it is ready for review? |
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: COMMENT
Risk: LOW
Summary: The chain-value validation tooling diff has required validation passing, but no current-cycle link-check run appeared after the check-links label flow, so this cannot be approved in this cycle.
Findings: None from the visible diff; approval is blocked because the current review-cycle link-check run was missing after the five-minute label flow.
Confidence: MEDIUM
|
Hi @eugene17kotov - this stale PR looks ready for reviewer action. Required CI is passing, and I do not see a creator-side blocker. I requested your review; could you please take a look when you have a chance? |
|
Hi @chico10117 - this PR is stale, and review should wait until required CI passes. Current blocker: CI not passing: Generate JSON and validate (isolated)=missing. Could you please fix CI and update the PR when it is ready? |
Closes #1943
Summary
chainvalue and network signals in its slug or source URLs.testnetaccepts known testnet aliases; genericmainnetmatcheschain=mainnet, the current network's canonical chain value, or a documented network-scoped alias.oneas global network signals or global mainnet aliases.maindata exceptions separately from future validation failures.maindata, and validates the result.Type of change
Scope
chainfieldLinks
Validation checklist
Validation
python3 -m compileall -q toolspython3 -m json.tool tools/schema.jsonpython3 -m json.tool tools/chain_validation_allowlist.jsonpython3 tools/test_chain_validation.pymainsnapshot.Reward
Reward address (Ethereum Mainnet USDC/USDT):
0x820a7bf90d944bb26bfD9b62Ab172Fc3A0829cB9AI disclosure: this patch was prepared with AI assistance; the changed logic was manually inspected and focused-tested.