Fix arg.name → arg.arg_name in macros.j2 byref smart pointer wrapping#63
Open
elliejs wants to merge 1 commit into
Open
Fix arg.name → arg.arg_name in macros.j2 byref smart pointer wrapping#63elliejs wants to merge 1 commit into
elliejs wants to merge 1 commit into
Conversation
Line 44 of init_outputs_byref uses arg.name, but ArgInfo has no such attribute — the field is arg.arg_name (introduced in 4338109). Jinja2 silently renders the missing attribute as empty string, producing broken C++ like: SomeType _ptr; _ptr = &; instead of: SomeType myArg_ptr; myArg_ptr = &myArg; This causes compile failures in 65 generated files (377 instances). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
elliejs
force-pushed
the
rename-arg-name-member
branch
from
ff318bc to
499cd39
Compare
Author
|
force push was editing the commit to be clear that I am still using claude. |
Member
|
Ok, that looks more manageable. Could you open a dummy PR to OCP to verify that it builds with this version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
init_outputs_byrefmacro (macros.j2:44) usesarg.namewhich doesn'texist on
ArgInfo— the correct field isarg.arg_name(since 4338109)broken C++ (
_ptr; _ptr = &;) instead of a template error