Fix rendering of placed sketches#584
Merged
Merged
Conversation
Member
|
@lorenzncode My PR #582 has a fix for the failing test. Also, have you pulled master into your branch? I don't see the examples submenu under |
Member
Author
|
My mistake, no, looks like I was not in sync. |
Member
|
I went ahead and merged my PR so that you will get the test fix when you pull the master branch. |
Member
Author
|
@jmwright I can add a test. I'm considering adding a new test file because test_app.py is more GUI focused and this can be tested with a non-GUI test. |
Member
|
@lorenzncode +1 on adding a non-GUI test file. The GUI tests are often challenging because there are some race conditions and some accidental leaks that happen between tests. It's hard to properly test a GUI in CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #583