fix(security): validate SetItemInSlotPacket targets MFFS ghost slots only#132
Open
Sweizeur wants to merge 1 commit into
Open
fix(security): validate SetItemInSlotPacket targets MFFS ghost slots only#132Sweizeur wants to merge 1 commit into
Sweizeur wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetItemInSlotPacket(mffs:set_slot_item) accepts any slot index andItemStackfrom the client and writes it into the player's currently open container menu without validation. A modified client can target player inventory slots (e.g. whileInventoryMenuis open) and inject arbitrary items.This patch restricts the handler to MFFS ghost filter slots only, matching the legitimate JEI usage in
BasicGhostIngredientHandler.Impact
mffs-5.4.27.jar(Minecraft 1.21.1 / NeoForge), used in the All the Mods 10 modpackLegitimate usage
The packet is sent from
BasicGhostIngredientHandlerwhen dragging JEI ingredients ontoSlotInventoryFilterslots in MFFS screens (FortronMenusubclasses).Fix
In
SetItemInSlotPacket.handle():!ctx.flow().isClientbound())FortronMenu0 <= slot < menu.slots.size()SlotInventoryFilterReproduction
mffs:set_slot_itemwith a player inventory slot index and an arbitraryItemStackwhile any container is open