Split VoteParty state and reward handling - #1570
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f223b8880
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8314e41add
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e925c5e58a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
af7c517 to
cff78b7
Compare
cff78b7 to
9414938
Compare
1 participant
Stacks on #1568.
Keeps
VotePartyas the public/event-facing coordinator while separating its two largest responsibilities:VotePartyStateowns default persistent total/voted-user storage and required-count calculationsVotePartyRewardHandlerowns reward delivery mechanics, global/random command execution, and fan-out iterationVotePartyretains threshold checks, reminders, command output, date-change reset events, and the existing public override hooksVotePartypublic methods (get/setTotalVotes,get/setVotedUsers,getRandomPlayerName,giveReward) so subclass integrations keep their previous behaviorCurrent VoteParty configuration, reward semantics, and public override behavior are intended to remain unchanged.