Skip to content

Split top voter loading and ranking - #1563

Merged
BenCodez merged 3 commits into
refactor/votingplugin-reward-registrationfrom
refactor/topvoter-handler
Aug 26, 2026
Merged

Split top voter loading and ranking#1563
BenCodez merged 3 commits into
refactor/votingplugin-reward-registrationfrom
refactor/topvoter-handler

Conversation

@BenCodez

@BenCodez BenCodez commented Aug 24, 2026

Copy link
Copy Markdown
Owner

Stacks on #1562.

Cleans up TopVoterHandler without changing its event-facing role:

  • extract historical/month ranking loading into TopVoterLoader
  • extract sorting and award-place mapping into TopVoterRanking
  • keep compatibility delegate methods on TopVoterHandler
  • remove VotingPluginMain.convertSet() and use the top-voter state directly
  • move the old first-load skull-cache warmup out of VotingPluginMain and preserve it as a one-shot asynchronous top-voter behavior after all first-pass rankings are sorted/limited
  • add tests for stored month-column parsing

The day/week/month change listener flow stays in TopVoterHandler for now so this PR does not mix event lifecycle behavior with the loading/ranking extraction.

@BenCodez
BenCodez marked this pull request as ready for review August 25, 2026 23:49
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01215e22c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenCodez
BenCodez force-pushed the refactor/topvoter-handler branch from 01215e2 to 7712ea1 Compare August 26, 2026 00:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 53998ea0fb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread VotingPlugin/src/main/java/com/bencodez/votingplugin/topvoter/TopVoterState.java Outdated
@BenCodez
BenCodez merged commit 192c114 into master Aug 26, 2026
4 checks passed
@BenCodez
BenCodez deleted the refactor/topvoter-handler branch August 26, 2026 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant