refactor(cspSsrNonce): refactor html injection - #738
Open
GalacticHypernova wants to merge 10 commits into
Open
Conversation
|
@GalacticHypernova is attempting to deploy a commit to the Baroshem's projects Team on Vercel. A member of the Team first needs to authorize it. |
GalacticHypernova
marked this pull request as ready for review
July 18, 2026 08:48
GalacticHypernova
marked this pull request as draft
July 18, 2026 09:36
GalacticHypernova
marked this pull request as ready for review
July 18, 2026 13:13
GalacticHypernova
marked this pull request as draft
July 18, 2026 17:11
GalacticHypernova
marked this pull request as ready for review
July 19, 2026 04:07
Contributor
Author
|
There may be a way to improve the performance of this fix by converting from a negative look-behind to a regular preceding match (negative look-behind is a slower op), which I tried, but I couldn't get it to work on my test case, so due to the urgency of this PR to patch the existing XSS risks I will keep working on it independently and open a new PR when I find the solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This PR introduces several changes and fixes issues brought on by #670 and #710 :
While I couldn't seem to get a minimal test case to demonstrate it, I did encounter it myself in my own app:

Where some of the data in NUXT_DATA has gotten malformed:

With these changes, the app loads with no issues
Checklist: